From 058992ea9fc62a9f79ab90eaebecb267469795a7 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Fri, 18 Apr 2025 22:16:35 +0200 Subject: [lldb] Fix Python GIL-not-held issue in CreateStructuredDataFromScriptObject (#136309) TestStructuredDataAPI.py fails with Python debug build ver. 3.12+ due to call to Py_XINCREF while GIL is not held. --- .../source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp') diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp b/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp index a9c8127..553ee7e 100644 --- a/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp +++ b/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp @@ -1569,10 +1569,10 @@ StructuredData::ObjectSP ScriptInterpreterPythonImpl::CreateStructuredDataFromScriptObject( ScriptObject obj) { void *ptr = const_cast(obj.GetPointer()); + Locker py_lock(this, Locker::AcquireLock | Locker::NoSTDIN, Locker::FreeLock); PythonObject py_obj(PyRefType::Borrowed, static_cast(ptr)); if (!py_obj.IsValid() || py_obj.IsNone()) return {}; - Locker py_lock(this, Locker::AcquireLock | Locker::NoSTDIN, Locker::FreeLock); return py_obj.CreateStructuredObject(); } -- cgit v1.1