From de346cf2ac850be793ee7fc31f99a7671331c289 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 23 Oct 2020 09:26:11 -0700 Subject: [lldb] Redesign Target::GetUtilityFunctionForLanguage API This patch redesigns the Target::GetUtilityFunctionForLanguage API: - Use a unique_ptr instead of a raw pointer for the return type. - Wrap the result in an llvm::Expected instead of using a Status object as an I/O parameter. - Combine the action of "getting" and "installing" the UtilityFunction as they always get called together. - Pass std::strings instead of const char* and std::move them where appropriate. There's more room for improvement but I think this tackles the most prevalent issues with the current API. Differential revision: https://reviews.llvm.org/D90011 --- lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp') diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp index 40f6f6c2..e8cc90e6 100644 --- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp +++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp @@ -2647,7 +2647,7 @@ addr_t ProcessGDBRemote::GetImageInfoAddress() { llvm::Expected list = GetLoadedModuleList(); if (!list) { Log *log(ProcessGDBRemoteLog::GetLogIfAllCategoriesSet(GDBR_LOG_PROCESS)); - LLDB_LOG_ERROR(log, list.takeError(), "Failed to read module list: {0}"); + LLDB_LOG_ERROR(log, list.takeError(), "Failed to read module list: {0}."); } else { addr = list->m_link_map; } -- cgit v1.1