From 5b18ddb6d1b64c5d9b9d6f8b70470925300b3973 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 24 Jan 2019 04:17:59 +0000 Subject: BreakpadRecords: Address post-commit feedback Summary: This addresses the issues raised in D56844. It removes the accessors from the breakpad record structures by making the fields public. Also, I refactor the UUID parsing code to remove hard-coded constants. Reviewers: lemo Subscribers: clayborg, lldb-commits Differential Revision: https://reviews.llvm.org/D57037 llvm-svn: 352021 --- lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp') diff --git a/lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp b/lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp index c7b5a9943a5c..8825c83f7476 100644 --- a/lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp +++ b/lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp @@ -32,13 +32,13 @@ llvm::Optional
Header::parse(llvm::StringRef text) { return llvm::None; llvm::Triple triple; - triple.setArch(Module->getArch()); - triple.setOS(Module->getOS()); + triple.setArch(Module->Arch); + triple.setOS(Module->OS); std::tie(line, text) = text.split('\n'); auto Info = InfoRecord::parse(line); - UUID uuid = Info && Info->getID() ? Info->getID() : Module->getID(); + UUID uuid = Info && Info->ID ? Info->ID : Module->ID; return Header{ArchSpec(triple), std::move(uuid)}; } -- cgit v1.2.3