From 4f23bee060f6a6582ba4896d8505ee9320f162c4 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Thu, 4 Oct 2012 10:06:38 +0000 Subject: Prefer StringRef::startswith to the strncmp/strlen contraption. This may be slightly more efficient and is definitely more readable. llvm-svn: 165217 --- clang/lib/Driver/OptTable.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'clang/lib/Driver/OptTable.cpp') diff --git a/clang/lib/Driver/OptTable.cpp b/clang/lib/Driver/OptTable.cpp index 257f353..e108106 100644 --- a/clang/lib/Driver/OptTable.cpp +++ b/clang/lib/Driver/OptTable.cpp @@ -159,10 +159,11 @@ Arg *OptTable::ParseOneArg(const ArgList &Args, unsigned &Index) const { // FIXME: This is searching much more than necessary, but I am // blanking on the simplest way to make it fast. We can solve this // problem when we move to TableGen. + StringRef StrRef(Str); for (; Start != End; ++Start) { // Scan for first option which is a proper prefix. for (; Start != End; ++Start) - if (strncmp(Str, Start->Name, strlen(Start->Name)) == 0) + if (StrRef.startswith(Start->Name)) break; if (Start == End) break; -- cgit v1.1