From 9c426524f8c1e0cd3fb1b05ceefb903629a4cda8 Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Tue, 29 Jul 2008 23:18:29 +0000 Subject: Rework codegen emission of globals - No (intended) functionality change. - Primary purpose is to clearly separate (lazy) construction of globals that are a forward declaration or tentative definition from those that are the final definition. - Lazy construction is now encapsulated in GetAddrOf{Function,GlobalVar} while final definitions are constructed in EmitGlobal{Function,Var}Definition. - External interface for dealing with globals is now limited to EmitGlobal and GetAddrOf{Function,GlobalVar}. - Also updated helper functions dealing with statics, annotations, and ctors to be private. llvm-svn: 54179 --- clang/lib/CodeGen/ModuleBuilder.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'clang/lib/CodeGen/ModuleBuilder.cpp') diff --git a/clang/lib/CodeGen/ModuleBuilder.cpp b/clang/lib/CodeGen/ModuleBuilder.cpp index 3fa086f..201092f 100644 --- a/clang/lib/CodeGen/ModuleBuilder.cpp +++ b/clang/lib/CodeGen/ModuleBuilder.cpp @@ -66,7 +66,9 @@ namespace { return; if (FunctionDecl *FD = dyn_cast(D)) { - Builder->EmitFunction(FD); + Builder->EmitGlobal(FD); + } else if (VarDecl *VD = dyn_cast(D)) { + Builder->EmitGlobal(VD); } else if (isa(D)){ //Forward declaration. Only used for type checking. } else if (ObjCProtocolDecl *PD = dyn_cast(D)){ @@ -85,8 +87,6 @@ namespace { // Ignore - generated when the implementation decl is CodeGen'd } else if (ObjCMethodDecl *OMD = dyn_cast(D)){ Builder->EmitObjCMethod(OMD); - } else if (VarDecl *VD = dyn_cast(D)) { - Builder->EmitGlobalVar(VD); } else if (isa(D) || isa(D)) { // Forward declaration. Only used for type checking. } else if (ObjCMethodDecl *OMD = dyn_cast(D)){ -- cgit v1.1