From 4cf01ed75e35e7bd3ef8ef1a2192c7f4656ab545 Mon Sep 17 00:00:00 2001 From: Michael Liao Date: Wed, 18 Mar 2020 01:43:20 -0400 Subject: [hip] Revise `GlobalDecl` constructors. NFC. Summary: - https://reviews.llvm.org/D68578 revises the `GlobalDecl` constructors to ensure all GPU kernels have `ReferenceKenelKind` initialized properly with an explicit constructor and static one. But, there are lots of places using the implicit constructor triggering the assertion on non-GPU kernels. That's found in compilation of many tests and workloads. - Fixing all of them may change more code and, more importantly, all of them assumes the default kernel reference kind. This patch changes that constructor to tell `CUDAGlobalAttr` and construct `GlobalDecl` properly. Reviewers: yaxunl Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D76344 --- clang/lib/CodeGen/CodeGenModule.h | 3 --- 1 file changed, 3 deletions(-) (limited to 'clang/lib/CodeGen/CodeGenModule.h') diff --git a/clang/lib/CodeGen/CodeGenModule.h b/clang/lib/CodeGen/CodeGenModule.h index 77b9002..fc44866 100644 --- a/clang/lib/CodeGen/CodeGenModule.h +++ b/clang/lib/CodeGen/CodeGenModule.h @@ -711,9 +711,6 @@ public: CtorList &getGlobalCtors() { return GlobalCtors; } CtorList &getGlobalDtors() { return GlobalDtors; } - /// get GlobalDecl for non-ctor/dtor functions. - GlobalDecl getGlobalDecl(const FunctionDecl *FD); - /// getTBAATypeInfo - Get metadata used to describe accesses to objects of /// the given type. llvm::MDNode *getTBAATypeInfo(QualType QTy); -- cgit v1.1