aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/CodeGen/MachineBasicBlock.cpp
AgeCommit message (Collapse)AuthorFilesLines
2012-06-15Remove assignments which aren't used afterwards.Bill Wendling1-3/+1
llvm-svn: 158535
2012-04-24MachineBasicBlock::SplitCriticalEdge() should follow LLVM IR variant and ↵Evan Cheng1-0/+5
refuse to break edge to EH landing pad. rdar://11300144 llvm-svn: 155470
2012-04-16Fix updateTerminator to be resiliant to degenerate terminators whereChandler Carruth1-7/+29
both fallthrough and a conditional branch target the same successor. Gracefully delete the conditional branch and introduce any unconditional branch needed to reach the actual successor. This fixes memory corruption in 2009-06-15-RegScavengerAssert.ll and possibly other tests. Also, while I'm here fix a latent bug I spotted by inspection. I never applied the same fundamental fix to this fallthrough successor finding logic that I did to the logic used when there are no conditional branches. As a consequence it would have selected landing pads had they be aligned in just the right way here. I don't have a test case as I spotted this by inspection, and the previous time I found this required have of TableGen's source code to produce it. =/ I hate backend bugs. ;] Thanks to Jim Grosbach for helping me reason through this and reviewing the fix. llvm-svn: 154867
2012-03-28Allow removeLiveIn to be called with a register that isn't live-in.Jakob Stoklund Olesen1-2/+2
This avoids the silly double search: if (isLiveIn(Reg)) removeLiveIn(Reg); llvm-svn: 153592
2012-03-07Added MachineBasicBlock::getFullName() to standardize/factor codegen ↵Andrew Trick1-0/+12
diagnostics. llvm-svn: 152176
2012-02-10Cache iterators. Some of these are expensive to create.Benjamin Kramer1-14/+16
llvm-svn: 150214
2012-02-09Preserve physreg kills in MachineBasicBlock::SplitCriticalEdge.Lang Hames1-4/+7
Failure to preserve kills was causing LiveIntervals to miss some EFLAGS live ranges. Unfortunately I've been unable to reduce a good test case yet. llvm-svn: 150152
2012-01-26Update comment for r149070.Chad Rosier1-3/+1
llvm-svn: 149075
2012-01-26Replace the use of isPredicable() with isPredicated() inChad Rosier1-3/+2
MachineBasicBlock::canFallThrough(). We're interested in the state of the instruction (i.e., is this a barrier or not?), not if the instruction is predicable or not. rdar://10501092 llvm-svn: 149070
2011-12-20Add some constantness to BranchProbabilityInfo and BlockFrequnencyInfo.Jakub Staszak1-2/+12
llvm-svn: 146986
2011-12-14- Add MachineInstrBundle.h and MachineInstrBundle.cpp. This includes a functionEvan Cheng1-20/+58
to finalize MI bundles (i.e. add BUNDLE instruction and computing register def and use lists of the BUNDLE instruction) and a pass to unpack bundles. - Teach more of MachineBasic and MachineInstr methods to be bundle aware. - Switch Thumb2 IT block to MI bundles and delete the hazard recognizer hack to prevent IT blocks from being broken apart. llvm-svn: 146542
2011-12-07Add bundle aware API for querying instruction properties and switch the codeEvan Cheng1-3/+3
generator to it. For non-bundle instructions, these behave exactly the same as the MC layer API. For properties like mayLoad / mayStore, look into the bundle and if any of the bundled instructions has the property it would return true. For properties like isPredicable, only return true if *all* of the bundled instructions have the property. For properties like canFoldAsLoad, isCompare, conservatively return false for bundles. llvm-svn: 146026
2011-12-06First chunk of MachineInstr bundle support.Evan Cheng1-26/+69
1. Added opcode BUNDLE 2. Taught MachineInstr class to deal with bundled MIs 3. Changed MachineBasicBlock iterator to skip over bundled MIs; added an iterator to walk all the MIs 4. Taught MachineBasicBlock methods about bundled MIs llvm-svn: 145975
2011-12-06Pretty-print basic block alignment.Jakob Stoklund Olesen1-2/+6
llvm-svn: 145965
2011-11-23Handle the case of a no-return invoke correctly. It actually still hasChandler Carruth1-0/+8
successors, they just are all landing pad successors. We handle this the same way as no successors. Comments attached for the next person to wade through here and another lovely test case courtesy of Benjamin Kramer's bugpoint reduction. llvm-svn: 145098
2011-11-22Fix a devilish miscompile exposed by block placement. TheChandler Carruth1-2/+8
updateTerminator code didn't correctly handle EH terminators in one very specific case. AnalyzeBranch would find no terminator instruction, and so the fallback in updateTerminator is to assume fallthrough. This is correct, but the destination of the fallthrough was assumed to be the first successor. This is *almost always* true, but in certain cases the loop transformations will cause the landing pad to be the first successor! Instead of this brittle logic, actually look through the successors for a non-landing-pad accessor, and to assert if more than one is found. This will hopefully fix some (if not all) of the self host miscompiles with block placement. Thanks to Benjamin Kramer for reporting, Nick Lewycky for an initial stab at a reduction, and Duncan for endless advice on EH (which I know nothing about) as well as reviewing the actual fix. llvm-svn: 145062
2011-10-14Update live-in lists when splitting critical edges.Jakob Stoklund Olesen1-0/+5
Fixes PR10814. Patch by Jan Sjödin! llvm-svn: 141960
2011-06-28- Rename TargetInstrDesc, TargetOperandInfo to MCInstrDesc and MCOperandInfo andEvan Cheng1-1/+0
sink them into MC layer. - Added MCInstrInfo, which captures the tablegen generated static data. Chang TargetInstrInfo so it's based off MCInstrInfo. llvm-svn: 134021
2011-06-17getSuccWeight returns now default 0 if Weights vector is empty.Jakub Staszak1-2/+4
llvm-svn: 133271
2011-06-17Allow empty Weights vector.Jakub Staszak1-1/+2
llvm-svn: 133265
2011-06-16Introduce MachineBranchProbabilityInfo class, which has similar API toJakub Staszak1-7/+69
BranchProbabilityInfo (expect setEdgeWeight which is not available here). Branch Weights are kept in MachineBasicBlocks. To turn off this analysis set -use-mbpi=false. llvm-svn: 133184
2011-06-16Test commit.Jakub Staszak1-7/+7
llvm-svn: 133174
2011-05-29Fix PR10046 by updating LiveVariables kill info when splitting live ranges.Jakob Stoklund Olesen1-2/+39
This only affects targets like Mips where branch instructions may kill virtual registers. Most other targets branch on flag values, so virtual registers are not involved. The problem is that MachineBasicBlock::updateTerminator deletes branches and inserts new ones while LiveVariables keeps a list of pointers to instructions that kill virtual registers. That list wasn't properly updated in MBB::SplitCriticalEdge. llvm-svn: 132298
2011-04-18Simplify declarations slightly by using typedefs.Eli Friedman1-4/+2
llvm-svn: 129720
2011-02-04Add LiveIntervals::getLastSplitPoint().Jakob Stoklund Olesen1-0/+10
A live range cannot be split everywhere in a basic block. A split must go before the first terminator, and if the variable is live into a landing pad, the split must happen before the call that can throw. llvm-svn: 124894
2011-01-14Try for the third time to teach getFirstTerminator() about debug values.Jakob Stoklund Olesen1-2/+3
This time let's rephrase to trick gcc-4.3 into not miscompiling. llvm-svn: 123432
2011-01-14Revert r123419. It still breaks llvm-gcc-i386-linux-selfhost.Jakob Stoklund Olesen1-16/+5
llvm-svn: 123423
2011-01-14Try again to teach getFirstTerminator() about debug values.Jakob Stoklund Olesen1-5/+16
Fix some callers to better deal with debug values. llvm-svn: 123419
2011-01-13Teach frame lowering to ignore debug values after the terminators.Jakob Stoklund Olesen1-0/+12
llvm-svn: 123399
2011-01-13Speculatively revert r123384 to make llvm-gcc-i386-linux-selfhost buildbot ↵Devang Patel1-16/+5
happy. llvm-svn: 123389
2011-01-13Teach MachineBasicBlock::getFirstTerminator to ignore debug values.Jakob Stoklund Olesen1-5/+16
It will still return an iterator that points to the first terminator or end(), but there may be DBG_VALUE instructions following the first terminator. llvm-svn: 123384
2011-01-13Add missing space in debug outputJakob Stoklund Olesen1-1/+1
llvm-svn: 123351
2011-01-09Replace TargetRegisterInfo::printReg with a PrintReg class that also works ↵Jakob Stoklund Olesen1-12/+1
without a TRI instance. Print virtual registers numbered from 0 instead of the arbitrary FirstVirtualRegister. The first virtual register is printed as %vreg0. TRI::NoRegister is printed as %noreg. llvm-svn: 123107
2010-11-02Don't try to split weird critical edges that really aren't:Jakob Stoklund Olesen1-2/+12
BB#1: derived from LLVM BB %bb.nph28 Live Ins: %AL Predecessors according to CFG: BB#0 TEST8rr %reg16384<kill>, %reg16384, %EFLAGS<imp-def>; GR8:%reg16384 JNE_4 <BB#2>, %EFLAGS<imp-use,kill> JMP_4 <BB#2> Successors according to CFG: BB#2 BB#2 These double CFG edges only ever occur in bugpoint-generated code, so there is no need to attempt something clever. llvm-svn: 117992
2010-10-30Add SkipPHIsAndLabels from PHIElimination to MachineBasicBlock. It is neededJakob Stoklund Olesen1-0/+7
elsewhere. llvm-svn: 117763
2010-10-26Teach MachineBasicBlock::print() to annotate instructions and blocks withJakob Stoklund Olesen1-3/+15
SlotIndexes when available. llvm-svn: 117392
2010-08-19Properly update MachineDominators when splitting critical edge.Evan Cheng1-2/+25
llvm-svn: 111574
2010-08-17Move the decision logic whether it's a good idea to split a critical edge to ↵Evan Cheng1-9/+1
clients. Also fixed an erroneous check. An edge is only a back edge when the from and to blocks are in the same loop. llvm-svn: 111256
2010-08-17Fix debug message.Evan Cheng1-1/+1
llvm-svn: 111250
2010-08-17PHI elimination should not break back edge. It can cause some significant ↵Evan Cheng1-2/+9
code placement issues. rdar://8263994 good: LBB0_2: mov r2, r0 . . . mov r1, r2 bne LBB0_2 bad: LBB0_2: mov r2, r0 . . . @ BB#3: mov r1, r2 b LBB0_2 llvm-svn: 111221
2010-07-07Add a getFirstNonPHI utility function.Dan Gohman1-0/+7
llvm-svn: 107778
2010-07-06Reapply r107655 with fixes; insert the pseudo instruction intoDan Gohman1-5/+25
the block before calling the expansion hook. And don't put EFLAGS in a mbb's live-in list twice. llvm-svn: 107691
2010-07-06Revert r107655.Dan Gohman1-25/+5
llvm-svn: 107668
2010-07-06Fix a bunch of custom-inserter functions to handle the case whereDan Gohman1-5/+25
the pseudo instruction is not at the end of the block. llvm-svn: 107655
2010-06-22Move PHIElimination's SplitCriticalEdge for MachineBasicBlocks outDan Gohman1-0/+79
into a utility routine, teach it how to update MachineLoopInfo, and make use of it in MachineLICM to split critical edges on demand. llvm-svn: 106555
2010-06-17Add a DebugLoc parameter to TargetInstrInfo::InsertBranch(). ThisStuart Hastings1-6/+7
addresses a longstanding deficiency noted in many FIXMEs scattered across all the targets. This effectively moves the problem up one level, replacing eleven FIXMEs in the targets with eight FIXMEs in CodeGen, plus one path through FastISel where we actually supply a DebugLoc, fixing Radar 7421831. llvm-svn: 106243
2010-04-13Eliminate MachineBasicBlock::const_livein_iterator and makeDan Gohman1-4/+5
MachineBasicBlock::livein_iterator a const_iterator, because clients shouldn't ever be using the iterator interface to mutate the livein set. llvm-svn: 101147
2010-04-01Reapply r100056. It doesn't look like it's the one that's causing a failure.Bill Wendling1-35/+23
llvm-svn: 100065
2010-03-31Revert r100056. It was causing a failure on MSVC.Bill Wendling1-23/+35
llvm-svn: 100062
2010-03-31Rewrite CorrectExtraCFGEdges() to make it more understandable.Bill Wendling1-35/+23
* Set the "DestA" and "DestB" according to how they're understood by the method. I.e., if one or both of them should point to the "fall through" block, then point to the fall through block. * Improve the loop that removes superfluous edges to be more understandable. llvm-svn: 100056
generated by cgit v1.1 at 2025-10-19 13:23:54 +0000