From 6fad891dfd5236002a2e64e26279c1d6dfa79565 Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Thu, 7 Apr 2022 17:15:56 -0300 Subject: stdio: Remove the usage of $(fno-unit-at-a-time) for siglist.c The siglist.c is built with -fno-toplevel-reorder to avoid compiler to reorder the compat assembly directives due an assembler issue [1] (fixed on 2.39). This patch removes the compiler flags by split the compat symbol generation in two phases. First the __sys_siglist and __sys_sigabbrev without any compat symbol directive is preprocessed to generate an assembly source code. This generate assembly is then used as input on a platform agnostic siglist.S which then creates the compat definitions. This prevents compiler to move any compat directive prior the _sys_errlist definition itself. Checked on a make check run-built-tests=no on all affected ABIs. Reviewed-by: Fangrui Song --- sysdeps/unix/sysv/linux/siglist-compat.c | 31 ----------------------------- sysdeps/unix/sysv/linux/siglist-compat.h | 34 ++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 31 deletions(-) delete mode 100644 sysdeps/unix/sysv/linux/siglist-compat.c create mode 100644 sysdeps/unix/sysv/linux/siglist-compat.h (limited to 'sysdeps/unix/sysv') diff --git a/sysdeps/unix/sysv/linux/siglist-compat.c b/sysdeps/unix/sysv/linux/siglist-compat.c deleted file mode 100644 index cbc7728..0000000 --- a/sysdeps/unix/sysv/linux/siglist-compat.c +++ /dev/null @@ -1,31 +0,0 @@ -/* Compatibility signal numbers and their names symbols. Linux version. - Copyright (C) 1997-2022 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - . */ - -#include - -#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_1) -DEFINE_COMPAT_SIGLIST (32, GLIBC_2_0) -#endif - -#if SHLIB_COMPAT (libc, GLIBC_2_1, GLIBC_2_3_3) -DEFINE_COMPAT_SIGLIST (64, GLIBC_2_1) -#endif - -#if SHLIB_COMPAT (libc, GLIBC_2_3_3, GLIBC_2_32) -DEFINE_COMPAT_SIGLIST (NSIG, GLIBC_2_3_3) -#endif diff --git a/sysdeps/unix/sysv/linux/siglist-compat.h b/sysdeps/unix/sysv/linux/siglist-compat.h new file mode 100644 index 0000000..2a98012 --- /dev/null +++ b/sysdeps/unix/sysv/linux/siglist-compat.h @@ -0,0 +1,34 @@ +/* Compatibility signal numbers and their names symbols. Linux version. + Copyright (C) 1997-2022 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +/* To get _NSIG definition. */ +#define _SIGNAL_H +#include + +#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_1) +DEFINE_COMPAT_SIGLIST (32, GLIBC_2_0) +#endif + +#if SHLIB_COMPAT (libc, GLIBC_2_1, GLIBC_2_3_3) +DEFINE_COMPAT_SIGLIST (64, GLIBC_2_1) +#endif + +#if SHLIB_COMPAT (libc, GLIBC_2_3_3, GLIBC_2_32) +DEFINE_COMPAT_SIGLIST (_NSIG, GLIBC_2_3_3) +#endif -- cgit v1.1