From 34e93d6c76b7a6eaf94697a172b958704fd33396 Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Mon, 12 Jan 2015 22:34:58 +0000 Subject: Fix ldbl-96 scalblnl for subnormal arguments (bug 17834). The ldbl-96 implementation of scalblnl (used for x86_64 and ia64) is incorrect for subnormal arguments (this is a separate bug from bug 17803, which is about underflowing results). There are two problems with the adjustments of subnormal arguments: the "two63" variable multiplied by is actually 0x1p52L not 0x1p63L, so is insufficient to make values normal, and then GET_LDOUBLE_EXP(es,x), used to extract the new exponent, extracts it into a variable that isn't used, while the value taken to by the new exponent is wrongly taken from the high part of the mantissa before the adjustment (hx). This patch fixes both those problems and adds appropriate tests. Tested for x86_64. [BZ #17834] * sysdeps/ieee754/ldbl-96/s_scalblnl.c (two63): Change value to 0x1p63L. (__scalblnl): Get new exponent of adjusted subnormal value from ES not HX. * math/libm-test.inc (scalbn_test_data): Add more tests. (scalbln_test_data): Likewise. --- sysdeps/ieee754/ldbl-96/s_scalblnl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'sysdeps/ieee754') diff --git a/sysdeps/ieee754/ldbl-96/s_scalblnl.c b/sysdeps/ieee754/ldbl-96/s_scalblnl.c index fca8470..5c2f38e 100644 --- a/sysdeps/ieee754/ldbl-96/s_scalblnl.c +++ b/sysdeps/ieee754/ldbl-96/s_scalblnl.c @@ -25,7 +25,7 @@ #include static const long double -two63 = 4.50359962737049600000e+15, +two63 = 0x1p63L, twom63 = 1.08420217248550443400e-19, huge = 1.0e+4900L, tiny = 1.0e-4900L; @@ -40,7 +40,7 @@ __scalblnl (long double x, long int n) if ((lx|(hx&0x7fffffff))==0) return x; /* +-0 */ x *= two63; GET_LDOUBLE_EXP(es,x); - k = (hx&0x7fff) - 63; + k = (es&0x7fff) - 63; } if (__builtin_expect(k==0x7fff, 0)) return x+x; /* NaN or Inf */ if (__builtin_expect(n< -50000, 0)) -- cgit v1.1