From 0b9af583a5c2d68085e88cece13952bf05dc4882 Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Wed, 28 Oct 2015 18:50:20 +0000 Subject: Fix i386/x86_64 fesetenv SSE exception clearing (bug 19181). The i386 and x86_64 versions of fesetenv, when called with FE_DFL_ENV or FE_NOMASK_ENV as argument, do not clear SSE exceptions raised in MXCSR. These arguments should, like other fenv_t values, represent the whole of the floating-point state, so such exceptions should be cleared; this patch adds the required clearing. (Discovered while working on bug 16068.) Tested for x86_64 and x86. [BZ #19181] * sysdeps/i386/fpu/fesetenv.c (__fesetenv): Clear already-raised SSE exceptions when argument is FE_DFL_ENV or FE_NOMASK_ENV. * sysdeps/x86_64/fpu/fesetenv.c (__fesetenv): Likewise. * math/test-fenv-clear-main.c: New file. * math/test-fenv-clear.c: Likewise. * math/Makefile (tests): Add test-fenv-clear. * sysdeps/x86/fpu/test-fenv-clear-sse.c: New file. * sysdeps/x86/fpu/Makefile [$(subdir) = math] (tests): Add test-fenv-clear-sse. [$(subdir) = math] (CFLAGS-test-fenv-clear-sse.c): New variable. --- sysdeps/i386/fpu/fesetenv.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'sysdeps/i386') diff --git a/sysdeps/i386/fpu/fesetenv.c b/sysdeps/i386/fpu/fesetenv.c index 9566e09..910aa09 100644 --- a/sysdeps/i386/fpu/fesetenv.c +++ b/sysdeps/i386/fpu/fesetenv.c @@ -72,6 +72,8 @@ __fesetenv (const fenv_t *envp) if (envp == FE_DFL_ENV) { + /* Clear SSE exceptions. */ + mxcsr &= ~FE_ALL_EXCEPT; /* Set mask for SSE MXCSR. */ mxcsr |= (FE_ALL_EXCEPT << 7); /* Set rounding to FE_TONEAREST. */ @@ -80,6 +82,8 @@ __fesetenv (const fenv_t *envp) } else if (envp == FE_NOMASK_ENV) { + /* Clear SSE exceptions. */ + mxcsr &= ~FE_ALL_EXCEPT; /* Do not mask exceptions. */ mxcsr &= ~(FE_ALL_EXCEPT << 7); /* Set rounding to FE_TONEAREST. */ -- cgit v1.1