From 7187efd0aa270c83c428ea6cd0e1cffc34b41a74 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Mon, 1 Aug 2022 15:49:07 +0200 Subject: malloc: Use __getrandom_nocancel during tcache initiailization Cancellation currently cannot happen at this point because dlopen as used by the unwind link always performs additional allocations for libgcc_s.so.1, even if it has been loaded already as a dependency of the main executable. But it seems prudent not to rely on this quirk. Reviewed-by: Adhemerval Zanella --- malloc/malloc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'malloc') diff --git a/malloc/malloc.c b/malloc/malloc.c index bd3c76e..430d204 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -254,6 +254,7 @@ /* For tcache double-free check. */ #include #include +#include /* Debugging: @@ -3153,7 +3154,7 @@ static uintptr_t tcache_key; static void tcache_key_initialize (void) { - if (__getrandom (&tcache_key, sizeof(tcache_key), GRND_NONBLOCK) + if (__getrandom_nocancel (&tcache_key, sizeof(tcache_key), GRND_NONBLOCK) != sizeof (tcache_key)) { tcache_key = random_bits (); -- cgit v1.1