From 51a7380b8968251a49a4c5b0bc7ed1af5b0512c6 Mon Sep 17 00:00:00 2001 From: Will Newton Date: Fri, 13 Jun 2014 16:37:12 +0100 Subject: malloc/malloc.c: Avoid calling sbrk unnecessarily with zero Due to my bad review suggestion for the fix for BZ #15089 a check was removed from systrim to prevent sbrk being called with a zero argument. Add the check back to avoid this useless work. ChangeLog: 2014-06-19 Will Newton * malloc/malloc.c (systrim): If extra is zero then return early. --- malloc/malloc.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'malloc') diff --git a/malloc/malloc.c b/malloc/malloc.c index d8fd8b4..41fd76a 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -2749,6 +2749,9 @@ systrim (size_t pad, mstate av) /* Release in pagesize units, keeping at least one page */ extra = (top_area - pad) & ~(pagesz - 1); + if (extra == 0) + return 0; + /* Only proceed if end of memory is where we last set it. This avoids problems if there were foreign sbrk calls. -- cgit v1.1