From 7b5bfe77836442b9aeb75cc520f0d1eb7f82be67 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Mon, 18 May 2020 15:21:04 +0200 Subject: elf: Assert that objects are relocated before their constructors run If we try to run constructors before relocation, this is always a dynamic linker bug. An assert is easier to notice than a call via an invalid function pointer (which may not even produce a valid call stack). Reviewed-by: Carlos O'Donell --- elf/dl-init.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/elf/dl-init.c b/elf/dl-init.c index 1234611..518824e 100644 --- a/elf/dl-init.c +++ b/elf/dl-init.c @@ -16,6 +16,7 @@ License along with the GNU C Library; if not, see . */ +#include #include #include #include @@ -28,6 +29,11 @@ typedef void (*init_t) (int, char **, char **); static void call_init (struct link_map *l, int argc, char **argv, char **env) { + /* If the object has not been relocated, this is a bug. The + function pointers are invalid in this case. (Executables do not + need relocation, and neither do proxy objects.) */ + assert (l->l_real->l_relocated || l->l_real->l_type == lt_executable); + if (l->l_init_called) /* This object is all done. */ return; -- cgit v1.1