From 4a2dd41cb533b9d93b8578677b80b9e94d6a3f96 Mon Sep 17 00:00:00 2001 From: "Gabriel F. T. Gomes" Date: Mon, 4 Feb 2019 08:44:35 -0200 Subject: powerpc64le: Remove test for GCC 6.2 The configure fragment for powerpc64le contains a test for the presence of several compiler builtins and of the __float128 type, which are provided by GCC 6.2 for powerpc64le. Since this configure test was added, the compiler version required to build glibc for powerpc64le was different than that required for the other architectures. Now that glibc requires GCC 6.2 globally (since commit ID 4dcbbc3b28aa), this patch removes the powerpc64le-specific test. Even tough the configure test checks for compiler features rather than compiler version, the intent of the test was to stop build attempts at early stages, if they had been configured with a too old compiler. It was not the intention of the test to detect compiler breakage (such as the removal of the required compiler features in future GCC versions), and glibc is not the place to test for compiler regressions, anyway. Tested for powerpc64le with GCC 6.2 (built with build-many-glibcs.py). Reviewed-by: Tulio Magno Quites Machado Filho --- ChangeLog | 5 ++++ sysdeps/powerpc/powerpc64/le/configure | 42 +------------------------------ sysdeps/powerpc/powerpc64/le/configure.ac | 28 --------------------- 3 files changed, 6 insertions(+), 69 deletions(-) diff --git a/ChangeLog b/ChangeLog index bc6adaa..488f29c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2019-02-20 Gabriel F. T. Gomes + + * sysdeps/powerpc/powerpc64/le/configure.ac: Remove test. + * sysdeps/powerpc/powerpc64/le/configure: Regenerate. + 2019-02-19 Wolfram Sang * nptl/pthread_mutex_trylock.c: Fix comment. diff --git a/sysdeps/powerpc/powerpc64/le/configure b/sysdeps/powerpc/powerpc64/le/configure index 66bb5dc..bca80ce 100644 --- a/sysdeps/powerpc/powerpc64/le/configure +++ b/sysdeps/powerpc/powerpc64/le/configure @@ -1,49 +1,9 @@ # This file is generated from configure.ac by Autoconf. DO NOT EDIT! # Local configure fragment for sysdeps/powerpc/powerpc64le. - -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking if $CC supports binary128 floating point type" >&5 -$as_echo_n "checking if $CC supports binary128 floating point type... " >&6; } -if ${libc_cv_compiler_powerpc64le_binary128_ok+:} false; then : - $as_echo_n "(cached) " >&6 -else - save_CFLAGS="$CFLAGS" -CFLAGS="$CFLAGS -Werror -mfloat128" -cat confdefs.h - <<_ACEOF >conftest.$ac_ext -/* end confdefs.h. */ - -__float128 a, b, c, d, e; -int i; - -__float128 -foobar (__float128 x) -{ - a = __builtin_nansq ("0"); - b = __builtin_huge_valq (); - c = __builtin_infq (); - d = __builtin_fabsq (x); - e = __builtin_nanq ("0"); - i = __builtin_signbit (x); - return __builtin_copysignq (x, x); -} - -_ACEOF -if ac_fn_c_try_compile "$LINENO"; then : - libc_cv_compiler_powerpc64le_binary128_ok=yes -else - libc_cv_compiler_powerpc64le_binary128_ok=no -fi -rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext -CFLAGS="$save_CFLAGS" -fi -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_compiler_powerpc64le_binary128_ok" >&5 -$as_echo "$libc_cv_compiler_powerpc64le_binary128_ok" >&6; } -if test "$libc_cv_compiler_powerpc64le_binary128_ok" != "yes"; then : - critic_missing="$critic_missing binary128 floating point type (GCC >= 6.2) is required on powerpc64le." -fi - OLD_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS $libc_cv_cc_submachine" + { $as_echo "$as_me:${as_lineno-$LINENO}: checking if the target machine is at least POWER8" >&5 $as_echo_n "checking if the target machine is at least POWER8... " >&6; } if ${libc_cv_target_power8_ok+:} false; then : diff --git a/sysdeps/powerpc/powerpc64/le/configure.ac b/sysdeps/powerpc/powerpc64/le/configure.ac index 20a49d8..7f2c9fb 100644 --- a/sysdeps/powerpc/powerpc64/le/configure.ac +++ b/sysdeps/powerpc/powerpc64/le/configure.ac @@ -1,34 +1,6 @@ GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory. # Local configure fragment for sysdeps/powerpc/powerpc64le. -dnl Require binary128 floating point support on powerpc64le (available in -dnl GCC 6.2). -AC_CACHE_CHECK([if $CC supports binary128 floating point type], - libc_cv_compiler_powerpc64le_binary128_ok, [dnl -save_CFLAGS="$CFLAGS" -CFLAGS="$CFLAGS -Werror -mfloat128" -AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ -__float128 a, b, c, d, e; -int i; - -__float128 -foobar (__float128 x) -{ - a = __builtin_nansq ("0"); - b = __builtin_huge_valq (); - c = __builtin_infq (); - d = __builtin_fabsq (x); - e = __builtin_nanq ("0"); - i = __builtin_signbit (x); - return __builtin_copysignq (x, x); -} -]])], - [libc_cv_compiler_powerpc64le_binary128_ok=yes], - [libc_cv_compiler_powerpc64le_binary128_ok=no]) -CFLAGS="$save_CFLAGS"]) -AS_IF([test "$libc_cv_compiler_powerpc64le_binary128_ok" != "yes"], - [critic_missing="$critic_missing binary128 floating point type (GCC >= 6.2) is required on powerpc64le."]) - dnl Require at least POWER8 on powerpc64le OLD_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS $libc_cv_cc_submachine" -- cgit v1.1