aboutsummaryrefslogtreecommitdiff
path: root/string/bug-strcoll2.c
AgeCommit message (Collapse)AuthorFilesLines
2017-01-01Update copyright dates with scripts/update-copyrights.Joseph Myers1-1/+1
2016-01-04Update copyright dates with scripts/update-copyrights.Joseph Myers1-1/+1
2015-10-09Fix typo in bug-strcoll2 (Bug 18589)Carlos O'Donell1-2/+1
Fix the copyright year and remove contributed by in the bug-strcoll2 test. In addition add the correct dependency on $(gen-locales) to ensure all the test locales are generated.
2015-10-08strcoll: Add bug-strcoll2 to testsuite (Bug 18589).Carlos O'Donell1-1/+1
Adds bug-strcoll2 to the string tests, along with the generation of required locales.
2015-10-08strcoll: Remove incorrect STRDIFF-based optimization (Bug 18589).Carlos O'Donell1-0/+93
The optimization introduced in commit f13c2a8dff2329c6692a80176262ceaaf8a6f74e, causes regressions in sorting for languages that have digraphs that change sort order, like cs_CZ which sorts ch between h and i. My analysis shows the fast-forwarding optimization in STRCOLL advances through a digraph while possibly stopping in the middle which results in a subsequent skipping of the digraph and incorrect sorting. The optimization is incorrect as implemented and because of that I'm removing it for 2.23, and I will also commit this fix for 2.22 where it was originally introduced. This patch reverts the optimization, introduces a new bug-strcoll2.c regression test that tests both cs_CZ.UTF-8 and da_DK.ISO-8859-1 and ensures they sort one digraph each correctly. The optimization can't be applied without regressing this test. Checked on x86_64, bug-strcoll2.c fails without this patch and passes after. This will also get a fix on 2.22 which has the same bug.