aboutsummaryrefslogtreecommitdiff
path: root/nptl/sysdeps/unix/sysv
AgeCommit message (Collapse)AuthorFilesLines
2014-04-09Move __PTHREAD_SPINS definition to architecture specific headerAdhemerval Zanella5-4/+15
This patch moves the __PTHREAD_SPINS definition to arch specific header since pthread_mutex_t layout is also arch specific. This leads to no need to defining __PTHREAD_MUTEX_HAVE_ELISION and thus removing of the undefined compiler warning.
2014-03-26Fix dwarf2 unwinding through futex functions.Andi Kleen2-336/+40
When profiling programs with lock problems with perf record -g dwarf, libunwind can currently not backtrace through the futex and unlock functions in pthread. This is because they use out of line sections, and those are not correctly described in dwarf2 (I believe needs dwarf3 or 4). This patch first removes the out of line sections. They only save a single jump, but cause a lot of pain. Then it converts the now inline lock code to use the now standard gas .cfi_* commands. With these changes libunwind/perf can backtrace through the futex functions now. Longer term it would be likely better to just use C futex() functions on x86 like all the other architectures. This would clean the code up even more.
2014-03-25PowerPC: Revert __PTHREAD_MUTEX_HAVE_ELISION changeAdhemerval Zanella1-2/+0
This patch revert 449282f2e0e850c29f6a9666058503d4734964f0.
2014-03-25PowerPC: Fix -Wundef warning for __PTHREAD_MUTEX_HAVE_ELISION.Adhemerval Zanella1-0/+2
2014-03-24S390: Fix -Wundef warning for __PTHREAD_MUTEX_HAVE_ELISION.Stefan Liebler1-0/+2
2014-02-10Use glibc_likely instead __builtin_expect.Ondřej Bílka15-30/+30
2014-02-05Fix tst-setgetname for Linux kernels < 2.6.33.Carlos O'Donell1-0/+14
Support for /proc/self/task/$tid/comm as added in Linux 2.6.33, therefore since the test tst-setgetname relies on this functionality to operate we must skip the test in kernels < 2.6.33. We wrap the checks with __ASSUME_PROC_PID_TASK_COMM such that in the future when we move arch_minimum_kernel to 2.6.33 we can remove this code.
2014-01-07S/390: Make jmp_buf extendible.Andreas Krebbel2-0/+68
2014-01-01Update copyright notices with scripts/update-copyrightsAllan McRae232-232/+232
2013-12-12Add test case for pthread_[sg]etname_np.Carlos O'Donell2-0/+302
This commit adds a testcase for pthread_setname_np and pthread_getname_np. The testcase itself has four tests to validate that these functions work as expected. The test is only enabled for Linux since it requires access to an alternate method for validating the functions work.
2013-12-09Fix CFI annotations in pthread_cond_timedwait for i486+Andreas Schwab1-2/+1
2013-12-04PowerPC64 ELFv2 ABI 4/6: Stack frame layout changesUlrich Weigand1-26/+34
This updates glibc for the changes in the ELFv2 relating to the stack frame layout. These are described in more detail here: http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01149.html http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01146.html Specifically, the "compiler and linker doublewords" were removed, which has the effect that the save slot for the TOC register is now at offset 24 rather than 40 to the stack pointer. In addition, a function may now no longer necessarily assume that its caller has set up a 64-byte register save area its use. To address the first change, the patch goes through all assembler files and replaces immediate offsets in instructions accessing the ABI-defined stack slots by symbolic offsets. Those already were defined in ucontext_i.sym and used in some of the context routines, but that doesn't really seem like the right place for those defines. The patch instead defines those symbolic offsets in sysdeps.h, in two variants for the old and new ABI, and uses them systematically in all assembler files, not just the context routines. The second change only affected a few assembler files that used the save area to temporarily store some registers. In those cases where this happens within a leaf function, this patch changes the code to store those registers to the "red zone" below the stack pointer. Otherwise, the functions already allocate a stack frame, and the patch changes them to add extra space in these frames as temporary space for the ELFv2 ABI.
2013-10-04PowerPC ugly symbol versioningAlan Modra1-9/+4
http://sourceware.org/ml/libc-alpha/2013-08/msg00090.html This patch fixes symbol versioning in setjmp/longjmp. The existing code uses raw versions, which results in wrong symbol versioning when you want to build glibc with a base version of 2.19 for LE. Note that the merging the 64-bit and 32-bit versions in novmx-lonjmp.c and pt-longjmp.c doesn't result in GLIBC_2.0 versions for 64-bit, due to the base in shlib_versions. * sysdeps/powerpc/longjmp.c: Use proper symbol versioning macros. * sysdeps/powerpc/novmx-longjmp.c: Likewise. * sysdeps/powerpc/powerpc32/bsd-_setjmp.S: Likewise. * sysdeps/powerpc/powerpc32/bsd-setjmp.S: Likewise. * sysdeps/powerpc/powerpc32/fpu/__longjmp.S: Likewise. * sysdeps/powerpc/powerpc32/fpu/setjmp.S: Likewise. * sysdeps/powerpc/powerpc32/mcount.c: Likewise. * sysdeps/powerpc/powerpc32/setjmp.S: Likewise. * sysdeps/powerpc/powerpc64/setjmp.S: Likewise. * nptl/sysdeps/unix/sysv/linux/powerpc/pt-longjmp.c: Likewise.
2013-09-04Remove --disable-versioning.Joseph Myers1-1/+1
2013-08-30Fix typos.Ondřej Bílka1-1/+1
2013-08-21Fix typos.Ondřej Bílka1-1/+1
2013-07-19Clean up whitespace in lock elision patches.Dominik Vogt12-28/+34
Signed-off-by: Carlos O'Donell <carlos@redhat.com>
2013-07-19Remove remains of rwlock elision which is not implemented yet.Dominik Vogt2-11/+0
Signed-off-by: Carlos O'Donell <carlos@redhat.com> --- nptl/ 2013-07-19 Dominik Vogt <vogt@de.ibm.com> * sysdeps/unix/sysv/linux/x86/elision-conf.c: Remove __rwlock_rtm_enabled and __rwlock_rtm_read_retries. (elision_init): Don't set __rwlock_rtm_enabled. * sysdeps/unix/sysv/linux/x86/elision-conf.h: Remove __rwlock_rtm_enabled.
2013-07-03Add x86 init-arch to nptlH.J. Lu2-0/+2
2013-07-02Add a configure option to enable lock elision and disable by defaultAndi Kleen1-0/+3
Can be enabled with --enable-lock-elision=yes at configure time.
2013-07-02Add elision to pthread_mutex_{try,timed,un}lockAndi Kleen8-5/+134
Add elision paths to the basic mutex locks. The normal path has a check for RTM and upgrades the lock to RTM when available. Trylocks cannot automatically upgrade, so they check for elision every time. We use a 4 byte value in the mutex to store the lock elision adaptation state. This is separate from the adaptive spin state and uses a separate field. Condition variables currently do not support elision. Recursive mutexes and condition variables may be supported at some point, but are not in the current implementation. Also "trylock" will not automatically enable elision unless some other lock call has been already called on the lock. This version does not use IFUNC, so it means every lock has one additional check for elision. Benchmarking showed the overhead to be negligible.
2013-07-02Add the low level infrastructure for pthreads lock elision with TSXAndi Kleen10-0/+480
Lock elision using TSX is a technique to optimize lock scaling It allows to run locks in parallel using hardware support for a transactional execution mode in 4th generation Intel Core CPUs. See http://www.intel.com/software/tsx for more Information. This patch implements a simple adaptive lock elision algorithm based on RTM. It enables elision for the pthread mutexes and rwlocks. The algorithm keeps track whether a mutex successfully elides or not, and stops eliding for some time when it is not. When the CPU supports RTM the elision path is automatically tried, otherwise any elision is disabled. The adaptation algorithm and its tuning is currently preliminary. The code adds some checks to the lock fast paths. Micro-benchmarks show little to no difference without RTM. This patch implements the low level "lll_" code for lock elision. Followon patches hook this into the pthread implementation Changes with the RTM mutexes: ----------------------------- Lock elision in pthreads is generally compatible with existing programs. There are some obscure exceptions, which are expected to be uncommon. See the manual for more details. - A broken program that unlocks a free lock will crash. There are ways around this with some tradeoffs (more code in hot paths) I'm still undecided on what approach to take here; have to wait for testing reports. - pthread_mutex_destroy of a lock mutex will not return EBUSY but 0. - There's also a similar situation with trylock outside the mutex, "knowing" that the mutex must be held due to some other condition. In this case an assert failure cannot be recovered. This situation is usually an existing bug in the program. - Same applies to the rwlocks. Some of the return values changes (for example there is no EDEADLK for an elided lock, unless it aborts. However when elided it will also never deadlock of course) - Timing changes, so broken programs that make assumptions about specific timing may expose already existing latent problems. Note that these broken programs will break in other situations too (loaded system, new faster hardware, compiler optimizations etc.) - Programs with non recursive mutexes that take them recursively in a thread and which would always deadlock without elision may not always see a deadlock. The deadlock will only happen on an early or delayed abort (which typically happens at some point) This only happens for mutexes not explicitely set to PTHREAD_MUTEX_NORMAL or PTHREAD_MUTEX_ADAPTIVE_NP. PTHREAD_MUTEX_NORMAL mutexes do not elide. The elision default can be set at configure time. This patch implements the basic infrastructure for elision.
2013-06-14Avoid access beyond memory bounds in pthread_attr_getaffinity_npSiddhesh Poyarekar1-1/+6
Resolves BZ #15618. pthread_attr_getaffinity_np may write beyond bounds of the input cpuset buffer if the size of the input buffer is smaller than the buffer present in the input pthread attributes. Fix is to copy to the extent of the minimum of the source and the destination.
2013-06-10x86*: Return syscall error for lll_futex_wake.Carlos O'Donell2-8/+10
It is very very possible that the futex syscall returns an error and that the caller of lll_futex_wake may want to look at that error and propagate the failure. This patch allows a caller to see the syscall error. There are no users of the syscall error at present, but future cleanups are now be able to check for the error. -- nplt/ 2013-06-10 Carlos O'Donell <carlos@redhat.com> * sysdeps/unix/sysv/linux/i386/lowlevellock.h (lll_futex_wake): Return syscall error. * sysdeps/unix/sysv/linux/x86_64/lowlevellock.h (lll_futex_wake): Return syscall error.
2013-06-06Remove trailing whitespace in nptl.Joseph Myers12-46/+46
2013-04-22Consolidate pthread_attr value validationSiddhesh Poyarekar1-17/+3
Define inline functions that wrap around validation for each of the pthread attributes to reduce duplication in code.
2013-04-11Extend i486 pthread_cond_timedwait to use futex syscall with absolute timeoutAndreas Schwab1-66/+315
2013-04-07sem_post.c: Include atomic.h.Carlos O'Donell1-0/+1
The sem_post.c file uses atomic functions without including atomic.h. Add `#include <atomic.h>' to the file to prevent any compile time warnings when other headers change and atomic.h isn't implicitly included. --- nptl/ 2013-04-07 Carlos O'Donell <carlos@redhat.com> * sysdeps/unix/sysv/linux/sem_post.c: Include atomic.h.
2013-04-04Fix static build when configured with --disable-hidden-pltSiddhesh Poyarekar1-1/+1
Fixes BZ #15337. Static builds fail with the following warning: /home/tools/glibc/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/x86_64/cancellation.S:80: undefined reference to `__GI___pthread_unwind' When the source is configured with --disable-hidden-plt. This is because the preprocessor conditional in cancellation.S only checks if the build is for SHARED, whereas hidden_def is defined appropriately only for a SHARED build that will have symbol versioning *and* hidden defs are enabled. The last case is false here.
2013-03-12Include atomic.h in generic lowlevellock.c.Carlos O'Donell1-1/+1
2013-03-04Rejigger i386 dl-sysdep.h files.Roland McGrath2-50/+31
2013-02-21Add priority inheritance futex support on sparc.David S. Miller1-0/+30
* sysdeps/unix/sysv/linux/sparc/lowlevellock.h (FUTEX_WAIT_REQUEUE_PI): Define. (FUTEX_CMP_REQUEUE_PI): Likewise. (lll_futex_wait_requeue_pi): Likewise. (lll_futex_timed_wait_requeue_pi): Likewise. (lll_futex_cmp_requeue_pi): Likewise.
2013-02-21nptl: Fix comment typo in fork.c.Carlos O'Donell1-1/+1
2013-02-18FUTEX_*_REQUEUE_PI support for non-x86 codeSiddhesh Poyarekar2-0/+58
Add FUTEX_*_REQUEUE_PI support for the default C code and also add implementations for s-390 and ppc.
2013-01-10Revert "Extend i486 pthread_cond_timedwait to use futex syscall with ↵Andreas Schwab1-315/+66
absolute timeout" This reverts commit 1bd57044e963abb886cb912beadea714815a3d5c.
2013-01-10Extend i486 pthread_cond_timedwait to use futex syscall with absolute timeoutAndreas Schwab1-66/+315
* sysdeps/unix/sysv/linux/i386/i486/pthread_cond_timedwait.S (__pthread_cond_timedwait): If possible use FUTEX_WAIT_BITSET to directly use absolute timeout.
2013-01-02Update copyright notices with scripts/update-copyrights.Joseph Myers220-225/+220
2013-01-01Add script to update copyright notices and reformat some to facilitate its use.Joseph Myers1-1/+1
2012-12-27Add sparc implementation of lll_futex_timed_wait_bitsetDavid S. Miller1-0/+13
nptl/ * sysdeps/unix/sysv/linux/sparc/lowlevellock.h (lll_futex_timed_wait_bitset): New macro.
2012-12-27[s390] Replace lll_futex_* assembly code with INTERNAL_SYSCALLSiddhesh Poyarekar1-74/+31
2012-12-08Fix some build warnings on s390xSiddhesh Poyarekar1-2/+2
2012-12-04Remove unused variable from powerpc sem_post.c.Joseph Myers1-2/+2
2012-11-21Remove unused variable from sem_post.c.Joseph Myers1-1/+1
2012-11-05[S390,PPC] Implement FUTEX_WAIT_BITSET for timedwait functionsSiddhesh Poyarekar3-1/+48
Since the FUTEX_WAIT operation takes a relative timeout, the pthread_cond_timedwait and other timed function implementations have to get a relative timeout from the absolute timeout parameter it gets before it makes the futex syscall. This value is then converted back into an absolute timeout within the kernel. This is a waste and has hence been improved upon by a FUTEX_WAIT_BITSET operation (OR'd with FUTEX_CLOCK_REALTIME to make the kernel use the realtime clock instead of the default monotonic clock). This was implemented only in the x86 and sh assembly code and not in the C code. This patch implements support for FUTEX_WAIT_BITSET whenever available (since linux-2.6.29) for s390 and powerpc.
2012-11-03Fix coding style in sparc lowlevellock.hDavid S. Miller1-2/+2
nptl/ * sysdeps/unix/sysv/linux/sparc/lowlevellock.h (BUSY_WAIT_NOP): Add missing spaces. (__cpu_relax): Likewise.
2012-10-28Define a BUSY_WAIT_NOP for sparc.David S. Miller5-0/+76
nptl/ * sysdeps/unix/sysv/linux/sparc/lowlevellock.h (BUSY_WAIT_NOP): Define when we have v9 instructions available. * sysdeps/unix/sysv/linux/sparc/sparc64/cpu_relax.S: New file. * sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9/cpu_relax.S: New file. * sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9/Makefile: New file. * sysdeps/unix/sysv/linux/sparc/sparc64/Makefile: Add cpu_relax to libpthread-routines.
2012-10-16Adjust mutex lock in condvar_cleanup if we got it from requeue_piSiddhesh Poyarekar4-4/+17
This completes the fix to bz #14652.
2012-10-10Take lock in pthread_cond_wait cleanup handler only when neededSiddhesh Poyarekar5-8/+65
[BZ #14652] When a thread waiting in pthread_cond_wait with a PI mutex is cancelled after it has returned successfully from the futex syscall but just before async cancellation is disabled, it enters its cancellation handler with the mutex held and simply calling a mutex_lock again will result in a deadlock. Hence, it is necessary to see if the thread owns the lock and try to lock it only if it doesn't.
2012-10-05Unlock mutex before going back to waiting for PI mutexesSiddhesh Poyarekar4-171/+156
[BZ #14417] A futex call with FUTEX_WAIT_REQUEUE_PI returns with the mutex locked on success. If such a successful thread is pipped to the cond_lock by another spuriously woken waiter, it could be sent back to wait on the futex with the mutex lock held, thus causing a deadlock. So it is necessary that the thread relinquishes the mutex before going back to sleep.
2012-10-02Fix clone flag name in comment to CLONE_CHILD_CLEARTID.Siddhesh Poyarekar6-6/+6
generated by cgit v1.1 at 2024-10-13 20:39:20 +0000