aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-08-25s390: Move hwcaps/platform names out of _rtld_global_roFlorian Weimer5-64/+44
Changes to these arrays are often backported to stable releases, but additions to these arrays shift the offsets of the following _rltd_global_ro members, thus breaking the GLIBC_PRIVATE ABI. Obviously, this change is itself an internal ABI break, but at least it will avoid further ABI breaks going forward. Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2022-08-25Revert "Detect ld.so and libc.so version inconsistency during startup"Florian Weimer17-198/+45
This reverts commit 6f85dbf102ad7982409ba0fe96886caeb6389fef. Once this change hits the release branches, it will require relinking of all statically linked applications before static dlopen works again, for the majority of updates on release branches: The NEWS file is regularly updated with bug references, so the __libc_early_init suffix changes, and static dlopen cannot find the function anymore. While this ABI check is still technically correct (we do require rebuilding & relinking after glibc updates to keep static dlopen working), it is too drastic for stable release branches. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2022-08-24Add NT_LOONGARCH_* from Linux 5.19 to elf.hJoseph Myers1-0/+9
Add the new NT_LOONGARCH_* constants from Linux 5.19 to glibc's elf.h. Tested for x86_64.
2022-08-24Detect ld.so and libc.so version inconsistency during startupFlorian Weimer17-45/+198
The files NEWS, include/link.h, and sysdeps/generic/ldsodefs.h contribute to the version fingerprint used for detection. The fingerprint can be further refined using the --with-extra-version-id configure argument. _dl_call_libc_early_init is replaced with _dl_lookup_libc_early_init. The new function is used store a pointer to libc.so's __libc_early_init function in the libc_map_early_init member of the ld.so namespace structure. This function pointer can then be called directly, so the separate invocation function is no longer needed. The versioned symbol lookup needs the symbol versioning data structures, so the initialization of libc_map and libc_map_early_init is now done from _dl_check_map_versions, after this information becomes available. (_dl_map_object_from_fd does not set this up in time, so the initialization code had to be moved from there.) This means that the separate initialization code can be removed from dl_main because _dl_check_map_versions covers all maps, including the initial executable loaded by the kernel. The lookup still happens before relocation and the invocation of IFUNC resolvers, so IFUNC resolvers are protected from ABI mismatch. The __libc_early_init function pointer is not protected because so little code runs between the pointer write and the invocation (only dynamic linker code and IFUNC resolvers). Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2022-08-23Merge getopt patch from GnulibPaul Eggert1-1/+2
* posix/getopt.c [!_LIBC]: Merge _WIN32 patch from Gnulib so that these source files are identical. This makes no difference for glibc.
2022-08-23Merge _GL_UNUSED C23 patch from GnulibPaul Eggert2-4/+4
* posix/getopt.c (_getopt_initialize): * sysdeps/posix/tempname.c (try_dir, try_nocreate): Put _GL_UNUSED before args instead of after. This makes no difference for glibc. It is needed for Gnulib when being compiled on non-GCC C23 compilers.
2022-08-24LoongArch: Fix dl-machine.h code formatting.Xi Ruoyao1-8/+4
No functional change.
2022-08-23scripts/glibcelf.py: Add hashing supportFlorian Weimer2-0/+38
ELF and GNU hashes can now be computed using the elf_hash and gnu_hash functions. Reviewed-by: Carlos O'Donell <carlos@redhat.com> Tested-by: Carlos O'Donell <carlos@redhat.com>
2022-08-22hurd: Fix starting static binaries with stack protection enabledSamuel Thibault2-2/+22
gcc introduces gs:0x14 accesses in most functions, so we need some tcbhead to be ready very early during initialization. This configures a static area which can be referenced by various protected functions, until proper TLS is set up.
2022-08-22htl: Make pthread*_cond_timedwait register wref before releasing mutexSamuel Thibault2-8/+12
Otherwise another thread could be rightly trying to destroy the condition, see e.g. tst-cond20.
2022-08-22htl: make __pthread_hurd_cond_timedwait_internal check mutex is heldSamuel Thibault1-0/+4
Like __pthread_cond_timedwait_internal already does.
2022-08-22Add AArch64 HWCAP2_* constants from Linux 5.19Joseph Myers1-0/+9
Linux 5.19 adds more HWCAP2_* values for AArch64; add these to its bits/hwcap.h header in glibc. Tested with build-many-glibcs.py for aarch64-linux-gnu.
2022-08-22Add AGROUP from Linux 5.19 to sys/acct.h, remove Alpha version (bug 29502)Joseph Myers2-64/+3
Linux 5.19 adds a new accounting flag AGROUP; add it to the enumeration in sys/acct.h. This shows up that the Alpha-specific variant of this header has a different set of constants and struct acct, which appear to be the constants and structure layout from Linux 2.0. These were changed some time between Linux 2.0 and Linux 2.2; I see no evidence of an Alpha-specific layout or set of constants, but haven't checked the detailed Linux kernel history between those versions. Rather, it looks like tha Alpha-specific header was originally needed because of the use of types in the kernel structure (such as uid_t and gid_t) that had different sizes on Alpha, and when glibc was updated for changes to the structure and constants in the kernel 1998-10-02 Andreas Jaeger <aj@arthur.rhein-neckar.de> * sysdeps/unix/sysv/linux/sys/acct.h: Bring in sync with current linux 2.1 version. that simply omitted to do anything about the Alpha version. Thus, remove the Alpha version in order to get the updated definitions into use on Alpha, as I don't think the interfaces are actually different for Alpha with any kernel version supported by glibc. Tested for x86_64, and with build-many-glibcs.py for alpha-linux-gnu.
2022-08-22alpha: Fix generic brk system call emulation in __brk_call (bug 29490)Florian Weimer1-4/+3
The kernel special-cases the zero argument for alpha brk, and we can use that to restore the generic Linux error handling behavior. Fixes commit b57ab258c1140bc45464b4b9908713e3e0ee35aa ("Linux: Introduce __brk_call for invoking the brk system call").
2022-08-19hurd: Assume non-suid during bootstrapSamuel Thibault1-2/+7
We do not have a hurd data block only when bootstrapping the system, in which case we don't have a notion of suid yet anyway. This is needed, otherwise init_standard_fds would check that standard file descriptors are allocated, which is meaningless during bootstrap.
2022-08-18Use binutils 2.39 branch in build-many-glibcs.pyJoseph Myers1-1/+1
This patch makes build-many-glibcs.py use binutils 2.39 branch. Tested with build-many-glibcs.py (compilers and glibcs builds). Note: binutils 2.39 shows the same failures for i686-linux-gnu-no-pie, x86_64-linux-gnu-no-pie and x86_64-linux-gnu-x32-no-pie building the glibc testsuite as binutils mainline does.
2022-08-18S390: Fix werror=unused-variable in ifunc-impl-list.c.Stefan Liebler1-1/+3
If the architecture level set is high enough, no IFUNCs are used at all and the variable i would be unused. Then the build fails with: ../sysdeps/s390/multiarch/ifunc-impl-list.c: In function ‘__libc_ifunc_impl_list’: ../sysdeps/s390/multiarch/ifunc-impl-list.c:76:10: error: unused variable ‘i’ [-Werror=unused-variable] 76 | size_t i = max; | ^ cc1: all warnings being treated as errors
2022-08-18Ensure calculations happen with desired rounding mode in y1lf128Michael Hudson-Doyle1-0/+3
math/test-float128-y1 fails on x86_64 and ppc64el with gcc 12 and -O3, because code inside a block guarded by SET_RESTORE_ROUNDL is being moved after the rounding mode has been restored. Use math_force_eval to prevent this (and insert some math_opt_barrier calls to prevent code from being moved before the rounding mode is set). Fixes #29463 Reviewed-By: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
2022-08-17localedata: Convert French language locales (fr_*) to UTF-8Florian Weimer5-47/+47
2022-08-16Linux: Fix enum fsconfig_command detection in <sys/mount.h>Florian Weimer1-3/+3
The #ifdef FSOPEN_CLOEXEC check did not work because the macro was always defined in this header prior to the check, so that the <linux/mount.h> contents did not matter. Fixes commit 774058d72942249f71d74e7f2b639f77184160a6 ("linux: Fix sys/mount.h usage with kernel headers").
2022-08-16elf: Run tst-audit-tlsdesc, tst-audit-tlsdesc-dlopen everywhereFlorian Weimer1-16/+24
The test is valid for all TLS models, but we want to make a reasonable effort to test the GNU2 model specifically. For example, aarch64 defaults to GNU2, but does not have -mtls-dialect=gnu2, and the test was not run there. Suggested-by: Martin Coufal <mcoufal@redhat.com>
2022-08-15Move ip_mreqn structure from Linux to genericSamuel Thibault2-8/+13
I.e. from sysdeps/unix/sysv/linux/bits/in.h to netinet/in.h It is following both the BSD and Linux definitions. Reviewed-by: Florian Weimer <fweimer@redhat.com>
2022-08-15malloc: Do not use MAP_NORESERVE to allocate heap segmentsFlorian Weimer2-8/+1
Address space for heap segments is reserved in a mmap call with MAP_ANONYMOUS | MAP_PRIVATE and protection flags PROT_NONE. This reservation does not count against the RSS limit of the process or system. Backing memory is allocated using mprotect in alloc_new_heap and grow_heap, and at this point, the allocator expects the kernel to provide memory (subject to memory overcommit). The SIGSEGV that might generate due to MAP_NORESERVE (according to the mmap manual page) does not seem to occur in practice, it's always SIGKILL from the OOM killer. Even if there is a way that SIGSEGV could be generated, it is confusing to applications that this only happens for secondary heaps, not for large mmap-based allocations, and not for the main arena. Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
2022-08-15Linux: Terminate subprocess on late failure in tst-pidfd (bug 29485)Florian Weimer1-2/+5
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2022-08-15non-linux: bits/in.h: Add more RFC optionsSamuel Thibault1-0/+10
2022-08-12arm: Remove nested functionf rom relocate_pc24Adhemerval Zanella1-10/+13
Checked on arm-linux-gnueabihf.
2022-08-12linux: Fix sys/mount.h usage with kernel headersAdhemerval Zanella3-8/+137
Now that kernel exports linux/mount.h and includes it on linux/fs.h, its definitions might clash with glibc exports sys/mount.h. To avoid the need to rearrange the Linux header to be always after glibc one, the glibc sys/mount.h is changed to: 1. Undefine the macros also used as enum constants. This covers prior inclusion of <linux/mount.h> (for instance MS_RDONLY). 2. Include <linux/mount.h> based on the usual __has_include check (needs to use __has_include ("linux/mount.h") to paper over GCC bugs. 3. Define enum fsconfig_command only if FSOPEN_CLOEXEC is not defined. (FSOPEN_CLOEXEC should be a very close proxy.) 4. Define struct mount_attr if MOUNT_ATTR_SIZE_VER0 is not defined. (Added in the same commit on the Linux side.) This patch also adds some tests to check if including linux/fs.h and linux/mount.h after and before sys/mount.h does work. Checked on x86_64-linux-gnu. Reviewed-by: Florian Weimer <fweimer@redhat.com>
2022-08-12linux: Use compile_c_snippet to check linux/mount.h availabilityAdhemerval Zanella1-0/+5
Checked on x86_64-linux-gnu. Reviewed-by: Florian Weimer <fweimer@redhat.com>
2022-08-12linux: Mimic kernel defition for BLOCK_SIZEAdhemerval Zanella1-1/+1
To avoid possible warnings if the kernel header is included before sys/mount.h. Reviewed-by: Florian Weimer <fweimer@redhat.com>
2022-08-12linux: Use compile_c_snippet to check linux/pidfd.h availabilityAdhemerval Zanella1-3/+5
Instead of tying to a specific kernel version. Checked on x86_64-linux-gnu. Reviewed-by: Florian Weimer <fweimer@redhat.com>
2022-08-12glibcextract.py: Add compile_c_snippetAdhemerval Zanella1-0/+19
It might be used on tests to check if a snippet build with the provided compiler and flags. Reviewed-by: Florian Weimer <fweimer@redhat.com>
2022-08-12LoongArch: Add pointer mangling support.caiyinyu3-3/+74
2022-08-11AArch64: Fix typo in sve configure check (BZ# 29394)Wilco Dijkstra2-4/+4
Fix a typo in the SVE configure check. This fixes [BZ# 29394].
2022-08-11libio: Improve performance of IO locksWilco Dijkstra1-9/+19
Improve performance of recursive IO locks by adding a fast path for the single-threaded case. To reduce the number of memory accesses for locking/unlocking, only increment the recursion counter if the lock is already taken. On Neoverse V1, a microbenchmark with many small freads improved by 2.9x. Multithreaded performance improved by 2%. Reviewed-by: Cristian Rodríguez <crrodriguez@opensuse.org>
2022-08-11tst-process_madvise: Check process_madvise-syscall support.Stefan Liebler1-2/+5
So far this test checks if pidfd_open-syscall is supported, which was introduced with linux 5.3. The process_madvise-syscall was introduced with linux 5.10. Thus you'll get FAILs if you are running a kernel in between. This patch adds a check if the first process_madvise-syscall returns ENOSYS and in this case will fail with UNSUPPORTED. Reviewed-by: Florian Weimer <fweimer@redhat.com>
2022-08-10elf.h: Add ELFCOMPRESS_ZSTDFangrui Song1-0/+1
From the approved generic ABI proposal https://groups.google.com/g/generic-abi/c/satyPkuMisk ("Add new ch_type value: ELFCOMPRESS_ZSTD"). Reviewed-by: Florian Weimer <fweimer@redhat.com>
2022-08-10inet: Turn __ivaliduser into a compatibility symbolFlorian Weimer2-13/+8
It is not declared in a header file, and as the comment indicates, it is not expected to be used.
2022-08-09x86: Fix `#define STRCPY` guard in strcpy-sse2.SNoah Goldstein1-1/+1
`#ifndef STPCPY` is incorrect for checking if `STRCPY` is already defined. It doesn't end up mattering as the whole check is guarded by `#if IS_IN (libc)` but is incorrect none the less.
2022-08-09elf: Replace `strcpy` call with `memcpy` [BZ #29454]Noah Goldstein1-2/+3
GCC normally does this optimization for us in strlen_pass::handle_builtin_strcpy but only for optimized build. To avoid needing to include strcpy.S in the rtld build to support the debug build, just do the optimization by hand.
2022-08-08soft-fp: Add fixhf[uns][di|si] and float[uns][di|si]hfKito Cheng8-0/+360
Add more IEEE half conversion routines: - Convert 32-bit/64-bit integer to IEEE half. - Convert IEEE half to 32-bit/64-bit integer. They are required by RISC-V _Float16 support, tested with RISC-V GCC.
2022-08-05i386: Use cmpl instead of cmpAdhemerval Zanella2-12/+12
Clang cannot assemble cmp in the AT&T dialect mode.
2022-08-05i386: Use fldt instead of fld on e_logl.SAdhemerval Zanella1-2/+2
Clang cannot assemble fldt in the AT&T dialect mode.
2022-08-04i386: Replace movzx with movzblFangrui Song1-18/+18
Similar to 6720d36b6623c5e48c070d86acf61198b33e144e for x86-64. Clang cannot assemble movzx in the AT&T dialect mode. Change movzx to movzbl, which follows the AT&T dialect and is used elsewhere in the file.
2022-08-04dlfcn: Pass caller pointer to static dlopen implementation (bug 29446)Florian Weimer1-1/+1
Fixes commit 0c1c3a771eceec46e66ce1183cf988e2303bd373 ("dlfcn: Move dlopen into libc").
2022-08-04malloc: Correct the documentation of the top_pad defaultFlorian Weimer3-2/+3
DEFAULT_TOP_PAD is defined as 131072 in sysdeps/generic/malloc-machine.h.
2022-08-04i386: Remove RELA supportAdhemerval Zanella2-197/+1
Now that prelink is not support, there is no need to keep supporting rela for non bootstrap.
2022-08-04arm: Remove RELA supportAdhemerval Zanella2-106/+1
Now that prelink is not support, there is no need to keep supporting rela for non bootstrap.
2022-08-04Remove ldd libc4 supportAdhemerval Zanella13-136/+2
The older libc versions are obsolete for over twenty years now.
2022-08-04Assume only FLAG_ELF_LIBC6 suportLucas A. M. Magalhaes16-394/+14
The older libc versions are obsolete for over twenty years now. This patch removes the special flags for libc5 and libc4 and assumes that all libraries cached are libc6 compatible and use FLAG_ELF_LIBC6. Checked with a build for all affected architectures. Co-authored-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2022-08-04Remove left over LD_LIBRARY_VERSION usagesAdhemerval Zanella5-11/+0
The environment variable was removed by d2db60d8d830ef68c8d20a77ac3572d610aa40b1.