aboutsummaryrefslogtreecommitdiff
path: root/time
diff options
context:
space:
mode:
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>2021-03-02 09:02:02 -0300
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2021-06-15 10:42:11 -0300
commit8af344feb5ae3e6e3374a6cf2175b44cc904a94e (patch)
treed10bf6233515a791dcf9bcb3d764d61c965a0008 /time
parent7446e896334cdb5431997dcc30d7ca13768b467d (diff)
downloadglibc-8af344feb5ae3e6e3374a6cf2175b44cc904a94e.zip
glibc-8af344feb5ae3e6e3374a6cf2175b44cc904a94e.tar.gz
glibc-8af344feb5ae3e6e3374a6cf2175b44cc904a94e.tar.bz2
time: Add 64-bit time support for getdate
The getdate is basically a wrapper localtime and mktime. The 64-bit time support is done calling the 64-bit internal functions, there is no need to add a new symbol version. Checked on x86_64-linux-gnu and i686-linux-gnu. Reviewed-by: Lukasz Majewski <lukma@denx.de> Reviewed-by: Carlos O'Donell <carlos@redhat.com> Tested-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'time')
-rw-r--r--time/getdate.c22
-rw-r--r--time/tst-getdate.c14
2 files changed, 14 insertions, 22 deletions
diff --git a/time/getdate.c b/time/getdate.c
index 6e2f755..cdcc898 100644
--- a/time/getdate.c
+++ b/time/getdate.c
@@ -112,16 +112,16 @@ __getdate_r (const char *string, struct tm *tp)
size_t len;
char *datemsk;
char *result = NULL;
- time_t timer;
+ __time64_t timer;
struct tm tm;
- struct stat64 st;
- int mday_ok = 0;
+ struct __stat64_t64 st;
+ bool mday_ok = false;
datemsk = getenv ("DATEMSK");
if (datemsk == NULL || *datemsk == '\0')
return 1;
- if (__stat64 (datemsk, &st) < 0)
+ if (__stat64_time64 (datemsk, &st) < 0)
return 3;
if (!S_ISREG (st.st_mode))
@@ -219,8 +219,8 @@ __getdate_r (const char *string, struct tm *tp)
return 7;
/* Get current time. */
- timer = time_now ();
- __localtime_r (&timer, &tm);
+ timer = time64_now ();
+ __localtime64_r (&timer, &tm);
/* If only the weekday is given, today is assumed if the given day
is equal to the current day and next week if it is less. */
@@ -230,7 +230,7 @@ __getdate_r (const char *string, struct tm *tp)
tp->tm_year = tm.tm_year;
tp->tm_mon = tm.tm_mon;
tp->tm_mday = tm.tm_mday + (tp->tm_wday - tm.tm_wday + 7) % 7;
- mday_ok = 1;
+ mday_ok = true;
}
/* If only the month is given, the current month is assumed if the
@@ -242,7 +242,7 @@ __getdate_r (const char *string, struct tm *tp)
if (tp->tm_year == INT_MIN)
tp->tm_year = tm.tm_year + (((tp->tm_mon - tm.tm_mon) < 0) ? 1 : 0);
tp->tm_mday = first_wday (tp->tm_year, tp->tm_mon, tp->tm_wday);
- mday_ok = 1;
+ mday_ok = true;
}
/* If no hour, minute and second are given the current hour, minute
@@ -285,15 +285,13 @@ __getdate_r (const char *string, struct tm *tp)
call normalizes the struct tm. */
if ((!mday_ok && !check_mday (TM_YEAR_BASE + tp->tm_year, tp->tm_mon,
tp->tm_mday))
- || mktime (tp) == (time_t) -1)
+ || __mktime64 (tp) == (time_t) -1)
return 8;
return 0;
}
-#ifdef weak_alias
weak_alias (__getdate_r, getdate_r)
-#endif
-
+libc_hidden_def (__getdate_r)
struct tm *
getdate (const char *string)
diff --git a/time/tst-getdate.c b/time/tst-getdate.c
index c37ba30..3bb0e96 100644
--- a/time/tst-getdate.c
+++ b/time/tst-getdate.c
@@ -115,20 +115,14 @@ do_test (void)
{
setenv ("TZ", tests[i].tz, 1);
- int expected_err;
- if (sizeof (time_t) == 4 && tests[i].time64)
- expected_err = 8;
- else
- expected_err = 0;
-
tm = getdate (tests[i].str);
- TEST_COMPARE (getdate_err, expected_err);
- if (getdate_err != expected_err)
+ TEST_COMPARE (getdate_err, 0);
+ if (getdate_err != 0)
{
support_record_failure ();
printf ("%s\n", report_date_error ());
}
- else if (getdate_err == 0)
+ else
{
TEST_COMPARE (tests[i].tm.tm_mon, tm->tm_mon);
TEST_COMPARE (tests[i].tm.tm_year, tm->tm_year);
@@ -139,7 +133,7 @@ do_test (void)
}
struct tm tms;
- TEST_COMPARE (getdate_r (tests[i].str, &tms), expected_err);
+ TEST_COMPARE (getdate_r (tests[i].str, &tms), 0);
if (getdate_err == 0)
{
TEST_COMPARE (tests[i].tm.tm_mon, tms.tm_mon);