diff options
| author | Andreas Schwab <schwab@linux-m68k.org> | 2021-05-27 12:49:47 +0200 |
|---|---|---|
| committer | Andreas Schwab <schwab@linux-m68k.org> | 2021-06-01 17:12:33 +0200 |
| commit | 42d359350510506b87101cf77202fefcbfc790cb (patch) | |
| tree | 615cbbfb4a3863cb029c014137e7cae3b15f268e /sysdeps | |
| parent | 858045ad1c5ac1682288bbcb3676632b97a21ddf (diff) | |
| download | glibc-42d359350510506b87101cf77202fefcbfc790cb.zip glibc-42d359350510506b87101cf77202fefcbfc790cb.tar.gz glibc-42d359350510506b87101cf77202fefcbfc790cb.tar.bz2 | |
Use __pthread_attr_copy in mq_notify (bug 27896)
Make a deep copy of the pthread attribute object to remove a potential
use-after-free issue.
Diffstat (limited to 'sysdeps')
| -rw-r--r-- | sysdeps/unix/sysv/linux/mq_notify.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/sysdeps/unix/sysv/linux/mq_notify.c b/sysdeps/unix/sysv/linux/mq_notify.c index cc575a0..f7ddfe5 100644 --- a/sysdeps/unix/sysv/linux/mq_notify.c +++ b/sysdeps/unix/sysv/linux/mq_notify.c @@ -133,8 +133,11 @@ helper_thread (void *arg) (void) __pthread_barrier_wait (¬ify_barrier); } else if (data.raw[NOTIFY_COOKIE_LEN - 1] == NOTIFY_REMOVED) - /* The only state we keep is the copy of the thread attributes. */ - free (data.attr); + { + /* The only state we keep is the copy of the thread attributes. */ + pthread_attr_destroy (data.attr); + free (data.attr); + } } return NULL; } @@ -255,8 +258,7 @@ mq_notify (mqd_t mqdes, const struct sigevent *notification) if (data.attr == NULL) return -1; - memcpy (data.attr, notification->sigev_notify_attributes, - sizeof (pthread_attr_t)); + __pthread_attr_copy (data.attr, notification->sigev_notify_attributes); } /* Construct the new request. */ @@ -270,7 +272,10 @@ mq_notify (mqd_t mqdes, const struct sigevent *notification) /* If it failed, free the allocated memory. */ if (__glibc_unlikely (retval != 0)) - free (data.attr); + { + pthread_attr_destroy (data.attr); + free (data.attr); + } return retval; } |