diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2016-01-15 08:11:23 -0800 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2016-01-15 08:34:05 -0800 |
| commit | 0d32fcb814a7ea7e857a967e96e5c76205bd729b (patch) | |
| tree | 43704fc3a281552f1388cfd468032392b4fac660 /sysdeps/x86/bits | |
| parent | 09245377dac2c013155500ac0b3b05850813e3f8 (diff) | |
| download | glibc-0d32fcb814a7ea7e857a967e96e5c76205bd729b.zip glibc-0d32fcb814a7ea7e857a967e96e5c76205bd729b.tar.gz glibc-0d32fcb814a7ea7e857a967e96e5c76205bd729b.tar.bz2 | |
Add _STRING_INLINE_unaligned and string_private.h
As discussed in
https://sourceware.org/ml/libc-alpha/2015-10/msg00403.html
the setting of _STRING_ARCH_unaligned currently controls the external
GLIBC ABI as well as selecting the use of unaligned accesses withing
GLIBC.
Since _STRING_ARCH_unaligned was recently changed for AArch64, this
would potentially break the ABI in GLIBC 2.23, so split the uses and add
_STRING_INLINE_unaligned to select the string ABI. This setting must be
fixed for each target, while _STRING_ARCH_unaligned may be changed from
release to release. _STRING_ARCH_unaligned is used unconditionally in
glibc. But <bits/string.h>, which defines _STRING_ARCH_unaligned, isn't
included with -Os. Since _STRING_ARCH_unaligned is internal to glibc and
may change between glibc releases, it should be made private to glibc.
_STRING_ARCH_unaligned should defined in the new string_private.h heade
file which is included unconditionally from internal <string.h> for glibc
build.
2016-01-15 H.J. Lu <hongjiu.lu@intel.com>
Wilco Dijkstra <wdijkstr@arm.com>
[BZ #19462]
* bits/string.h (_STRING_ARCH_unaligned): Renamed to ...
(_STRING_INLINE_unaligned): This.
* include/string.h: Include <string_private.h>.
* string/bits/string2.h: Replace _STRING_ARCH_unaligned with
_STRING_INLINE_unaligned.
* sysdeps/aarch64/bits/string.h (_STRING_ARCH_unaligned): Removed.
(_STRING_INLINE_unaligned): New.
* sysdeps/aarch64/string_private.h: New file.
* sysdeps/generic/string_private.h: Likewise.
* sysdeps/m68k/m680x0/m68020/string_private.h: Likewise.
* sysdeps/s390/string_private.h: Likewise.
* sysdeps/x86/string_private.h: Likewise.
* sysdeps/m68k/m680x0/m68020/bits/string.h
(_STRING_ARCH_unaligned): Renamed to ...
(_STRING_INLINE_unaligned): This.
* sysdeps/s390/bits/string.h (_STRING_ARCH_unaligned): Renamed
to ...
(_STRING_INLINE_unaligned): This.
* sysdeps/sparc/bits/string.h (_STRING_ARCH_unaligned): Renamed
to ...
(_STRING_INLINE_unaligned): This.
* sysdeps/x86/bits/string.h (_STRING_ARCH_unaligned): Renamed
to ...
(_STRING_INLINE_unaligned): This.
Diffstat (limited to 'sysdeps/x86/bits')
| -rw-r--r-- | sysdeps/x86/bits/string.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sysdeps/x86/bits/string.h b/sysdeps/x86/bits/string.h index 1a0682b..e4e019f 100644 --- a/sysdeps/x86/bits/string.h +++ b/sysdeps/x86/bits/string.h @@ -20,8 +20,8 @@ # error "Never use <bits/string.h> directly; include <string.h> instead." #endif -/* The ix86 processors can access unaligned multi-byte variables. */ -#define _STRING_ARCH_unaligned 1 +/* Use the unaligned string inline ABI. */ +#define _STRING_INLINE_unaligned 1 /* Enable inline functions only for i486 or better when compiling for ia32. */ |