diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2015-06-09 21:07:30 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2015-06-09 21:07:30 +0000 |
| commit | 2f44ee08dbf51d39ef5692699cc35f93faf64db1 (patch) | |
| tree | b913fa3ca4962e28816eaf8a2d9fa03db0620ff2 /sysdeps/i386 | |
| parent | d3ab671c942ba15a5b20f383ce71e387f17ae2c4 (diff) | |
| download | glibc-2f44ee08dbf51d39ef5692699cc35f93faf64db1.zip glibc-2f44ee08dbf51d39ef5692699cc35f93faf64db1.tar.gz glibc-2f44ee08dbf51d39ef5692699cc35f93faf64db1.tar.bz2 | |
Fix regcomp wcscoll, wcscmp namespace (bug 18497).
regcomp brings in references to wcscoll, which isn't in all the
standards that contain regcomp. In turn, wcscoll brings in references
to wcscmp, also not in all those standards. This patch fixes this by
making those functions into weak aliases of __wcscoll and __wcscmp and
calling those names instead as needed.
Tested for x86_64 and x86 (testsuite, and that disassembly of
installed shared libraries is unchanged by the patch).
[BZ #18497]
* wcsmbs/wcscmp.c [!WCSCMP] (WCSCMP): Define as __wcscmp instead
of wcscmp.
(wcscmp): Define as weak alias of WCSCMP.
* wcsmbs/wcscoll.c (STRCOLL): Define as __wcscoll instead of
wcscoll.
(USE_HIDDEN_DEF): Define.
[!USE_IN_EXTENDED_LOCALE_MODEL] (wcscoll): Define as weak alias of
__wcscoll. Don't use libc_hidden_weak.
* wcsmbs/wcscoll_l.c (STRCMP): Define as __wcscmp instead of
wcscmp.
* sysdeps/i386/i686/multiarch/wcscmp-c.c
[SHARED] (libc_hidden_def): Define __GI___wcscmp instead of
__GI_wcscmp.
(weak_alias): Undefine and redefine.
* sysdeps/i386/i686/multiarch/wcscmp.S (wcscmp): Rename to
__wcscmp and define as weak alias of __wcscmp.
* sysdeps/x86_64/wcscmp.S (wcscmp): Likewise.
* include/wchar.h (__wcscmp): Declare. Use libc_hidden_proto.
(__wcscoll): Likewise.
(wcscmp): Don't use libc_hidden_proto.
(wcscoll): Likewise.
* posix/regcomp.c (build_range_exp): Call __wcscoll instead of
wcscoll.
* posix/regexec.c (check_node_accept_bytes): Likewise.
* conform/Makefile (test-xfail-XPG3/regex.h/linknamespace): Remove
variable.
(test-xfail-XPG4/regex.h/linknamespace): Likewise.
(test-xfail-POSIX/regex.h/linknamespace): Likewise.
Diffstat (limited to 'sysdeps/i386')
| -rw-r--r-- | sysdeps/i386/i686/multiarch/wcscmp-c.c | 4 | ||||
| -rw-r--r-- | sysdeps/i386/i686/multiarch/wcscmp.S | 7 |
2 files changed, 7 insertions, 4 deletions
diff --git a/sysdeps/i386/i686/multiarch/wcscmp-c.c b/sysdeps/i386/i686/multiarch/wcscmp-c.c index 165c56a..e3337d7 100644 --- a/sysdeps/i386/i686/multiarch/wcscmp-c.c +++ b/sysdeps/i386/i686/multiarch/wcscmp-c.c @@ -4,8 +4,10 @@ #ifdef SHARED # undef libc_hidden_def # define libc_hidden_def(name) \ - __hidden_ver1 (__wcscmp_ia32, __GI_wcscmp, __wcscmp_ia32); + __hidden_ver1 (__wcscmp_ia32, __GI___wcscmp, __wcscmp_ia32); #endif +#undef weak_alias +#define weak_alias(name, alias) extern __typeof (wcscmp) __wcscmp_ia32; diff --git a/sysdeps/i386/i686/multiarch/wcscmp.S b/sysdeps/i386/i686/multiarch/wcscmp.S index 43fe0a3..92c2c84 100644 --- a/sysdeps/i386/i686/multiarch/wcscmp.S +++ b/sysdeps/i386/i686/multiarch/wcscmp.S @@ -26,8 +26,8 @@ happened. */ #if IS_IN (libc) .text -ENTRY(wcscmp) - .type wcscmp, @gnu_indirect_function +ENTRY(__wcscmp) + .type __wcscmp, @gnu_indirect_function pushl %ebx cfi_adjust_cfa_offset (4) cfi_rel_offset (ebx, 0) @@ -43,5 +43,6 @@ ENTRY(wcscmp) cfi_adjust_cfa_offset (-4); cfi_restore (ebx) ret -END(wcscmp) +END(__wcscmp) +weak_alias (__wcscmp, wcscmp) #endif |