diff options
| author | Frédéric Bérat <fberat@redhat.com> | 2023-06-14 10:52:06 +0200 |
|---|---|---|
| committer | Siddhesh Poyarekar <siddhesh@sourceware.org> | 2023-06-19 09:14:56 -0400 |
| commit | 20b6b8e8a50874dd189687df8f6f8a11d4813b34 (patch) | |
| tree | dadbbe8e8c05cf8a9c647b9c9b3198c086fec475 /support/test-container.c | |
| parent | cf30aa43a5917f441c9438aaee201c53c8e1d76b (diff) | |
| download | glibc-20b6b8e8a50874dd189687df8f6f8a11d4813b34.zip glibc-20b6b8e8a50874dd189687df8f6f8a11d4813b34.tar.gz glibc-20b6b8e8a50874dd189687df8f6f8a11d4813b34.tar.bz2 | |
tests: replace read by xread
With fortification enabled, read calls return result needs to be checked,
has it gets the __wur macro enabled.
Note on read call removal from sysdeps/pthread/tst-cancel20.c and
sysdeps/pthread/tst-cancel21.c:
It is assumed that this second read call was there to overcome the race
condition between pipe closure and thread cancellation that could happen
in the original code. Since this race condition got fixed by
d0e3ffb7a58854248f1d5e737610d50cd0a60f46 the second call seems
superfluous. Hence, instead of checking for the return value of read, it
looks reasonable to simply remove it.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Diffstat (limited to 'support/test-container.c')
| -rw-r--r-- | support/test-container.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/support/test-container.c b/support/test-container.c index 20ea19a..788b091 100644 --- a/support/test-container.c +++ b/support/test-container.c @@ -1217,7 +1217,8 @@ main (int argc, char **argv) /* Get our "outside" pid from our parent. We use this to help with debugging from outside the container. */ - read (pipes[0], &child, sizeof(child)); + xread (pipes[0], &child, sizeof(child)); + close (pipes[0]); close (pipes[1]); sprintf (pid_buf, "%lu", (long unsigned)child); |