diff options
author | Siddhesh Poyarekar <siddhesh@sourceware.org> | 2022-04-06 20:53:24 +0530 |
---|---|---|
committer | Siddhesh Poyarekar <siddhesh@sourceware.org> | 2022-04-06 20:53:24 +0530 |
commit | 67e3b0c63c35769c1ba28fa2a32446332bb4fcef (patch) | |
tree | 30222f7961103558c51c99871cead59139e65fd5 /string/test-strcasestr.c | |
parent | dfc7bf8a24f63532da167cc7131227c1c4027ffb (diff) | |
download | glibc-67e3b0c63c35769c1ba28fa2a32446332bb4fcef.zip glibc-67e3b0c63c35769c1ba28fa2a32446332bb4fcef.tar.gz glibc-67e3b0c63c35769c1ba28fa2a32446332bb4fcef.tar.bz2 |
tests/string: Drop simple/stupid/builtin tests
In most cases the simple/stupid/builtin functions were in there to
benchmark optimized implementations against. Only in some cases the
functions are used to check expected results.
Remove these tests from IMPL() and only keep them in wherever they're
used for a specific purpose, e.g. to generate expected results.
This improves timing of `make subdirs=string` by over a minute and a
half (over 15%) on a Whiskey Lake laptop.
Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Reviewed-by: Noah Goldstein <libc-alpha@sourceware.org>
Diffstat (limited to 'string/test-strcasestr.c')
-rw-r--r-- | string/test-strcasestr.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/string/test-strcasestr.c b/string/test-strcasestr.c index b73bcfe..0d39c62 100644 --- a/string/test-strcasestr.c +++ b/string/test-strcasestr.c @@ -21,15 +21,15 @@ #include "test-string.h" -#define STRCASESTR simple_strcasestr +#define STRCASESTR c_strcasestr #define NO_ALIAS #define __strncasecmp strncasecmp #define __strnlen strnlen #include "strcasestr.c" - +/* Naive implementation to verify results. */ static char * -stupid_strcasestr (const char *s1, const char *s2) +simple_strcasestr (const char *s1, const char *s2) { ssize_t s1len = strlen (s1); ssize_t s2len = strlen (s2); @@ -53,8 +53,7 @@ stupid_strcasestr (const char *s1, const char *s2) typedef char *(*proto_t) (const char *, const char *); -IMPL (stupid_strcasestr, 0) -IMPL (simple_strcasestr, 0) +IMPL (c_strcasestr, 0) IMPL (strcasestr, 1) @@ -129,7 +128,7 @@ check1 (void) const char s2[] = "OK"; char *exp_result; - exp_result = stupid_strcasestr (s1, s2); + exp_result = simple_strcasestr (s1, s2); FOR_EACH_IMPL (impl, 0) check_result (impl, s1, s2, exp_result); } |