diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2017-08-16 20:33:59 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2017-08-16 20:33:59 +0000 |
| commit | 67f0aff0c63e5deaade7f6cc7758f5cb63344fb8 (patch) | |
| tree | 6cd8f38178b1ba6c4c73bf2f61d4e24df1e975dc /signal/Makefile | |
| parent | 87e7bf4d36af0a4622dc2687730f26d7d53003fe (diff) | |
| download | glibc-67f0aff0c63e5deaade7f6cc7758f5cb63344fb8.zip glibc-67f0aff0c63e5deaade7f6cc7758f5cb63344fb8.tar.gz glibc-67f0aff0c63e5deaade7f6cc7758f5cb63344fb8.tar.bz2 | |
Fix sigval namespace (bug 21944).
XPG4.2 defines the siginfo_t type, but not union sigval or its
contents (which were added in the 1993 edition of POSIX.1), resulting
in namespace violations for sigval, sival_int and sival_ptr for
signal.h and sys/wait.h for that standard because those headers
incorrectly expose those names in that case.
This patch fixes this problem. The public type in this case is union
sigval, but various places in the headers use the sigval_t name for
it; direct uses of union sigval are already properly guarded or in
headers not in XPG4.2. Now, sigval_t, although not a standard name,
does seem to be widely used outside glibc. The approach taken by this
patch is to make installed headers use the name __sigval_t instead.
__sigval_t is then defined to either union sigval or union __sigval
(where union __sigval has __-prefixed member names as well), depending
on whether there are any namespace issues with the union sigval name
and its members. In the case where union __sigval is used, sigval_t
is not defined at all, to avoid the problem of sigval_t having a C++
mangled name that depends on feature test macros. sigval_t is still
defined by signal.h if __USE_MISC (reflecting the nonstandard nature
of that name).
Tested for x86_64.
[BZ #21944]
* signal/bits/types/__sigval_t.h: New file.
* signal/Makefile (headers): Add bits/types/__sigval_t.h.
* signal/bits/types/sigval_t.h: Include <bits/types/__sigval_t.h>
and define sigval_t using __sigval_t.
* include/bits/types/__sigval_t.h: New file.
* bits/types/sigevent_t.h: Include <bits/types/__sigval_t.h>
instead of <bits/types/__sigval_t.h>.
(struct sigevent): Use __sigval_t instead of sigval_t.
* bits/types/siginfo_t.h: Include <bits/types/__sigval_t.h>
instead of <bits/types/__sigval_t.h>.
(siginfo_t): Use __sigval_t instead of sigval_t.
* sysdeps/unix/sysv/linux/bits/types/sigevent_t.h: Include
<bits/types/__sigval_t.h> instead of <bits/types/__sigval_t.h>.
(struct sigevent): Use __sigval_t instead of sigval_t.
* sysdeps/unix/sysv/linux/bits/types/siginfo_t.h: Include
<bits/types/__sigval_t.h> instead of <bits/types/__sigval_t.h>.
(siginfo_t): Use __sigval_t instead of sigval_t.
* signal/signal.h [__USE_MISC]: Include <bits/types/sigval_t.h>.
Diffstat (limited to 'signal/Makefile')
| -rw-r--r-- | signal/Makefile | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/signal/Makefile b/signal/Makefile index 8c9a7d1..a6a1289 100644 --- a/signal/Makefile +++ b/signal/Makefile @@ -30,7 +30,8 @@ headers := signal.h sys/signal.h \ bits/types/__sigset_t.h bits/types/sig_atomic_t.h \ bits/types/sigevent_t.h bits/types/siginfo_t.h \ bits/types/sigset_t.h bits/types/sigval_t.h \ - bits/types/stack_t.h bits/types/struct_sigstack.h + bits/types/stack_t.h bits/types/struct_sigstack.h \ + bits/types/__sigval_t.h routines := signal raise killpg \ sigaction sigprocmask kill \ |