aboutsummaryrefslogtreecommitdiff
path: root/nptl
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2017-12-18 22:55:28 +0000
committerJoseph Myers <joseph@codesourcery.com>2017-12-18 22:55:28 +0000
commit40c4162df6766fb1e8ede875ca8df25d8075d3a5 (patch)
treee01491086b528f4ffb83a02aba1ac1fee66e55d8 /nptl
parent5983df320af003a10ab2b965db1eecaca92c7056 (diff)
downloadglibc-40c4162df6766fb1e8ede875ca8df25d8075d3a5.zip
glibc-40c4162df6766fb1e8ede875ca8df25d8075d3a5.tar.gz
glibc-40c4162df6766fb1e8ede875ca8df25d8075d3a5.tar.bz2
Disable -Wrestrict for two nptl/tst-attr3.c tests.
nptl/tst-attr3 fails to build with GCC mainline because of (deliberate) aliasing between the second (attributes) and fourth (argument to thread start routine) arguments to pthread_create. Although both those arguments are restrict-qualified in POSIX, pthread_create does not actually dereference its fourth argument; it's an opaque pointer passed to the thread start routine. Thus, the aliasing is actually valid in this case, and it's deliberate in the test. So this patch makes the test disable -Wrestrict for the two pthread_create calls in question. (-Wrestrict was added in GCC 7, hence the __GNUC_PREREQ conditions, but the particular warning in question is new in GCC 8.) Tested compilation with build-many-glibcs.py for aarch64-linux-gnu. * nptl/tst-attr3.c: Include <libc-diag.h>. (do_test) [__GNUC_PREREQ (7, 0)]: Ignore -Wrestrict for two tests.
Diffstat (limited to 'nptl')
-rw-r--r--nptl/tst-attr3.c19
1 files changed, 19 insertions, 0 deletions
diff --git a/nptl/tst-attr3.c b/nptl/tst-attr3.c
index bc23386..420a7db 100644
--- a/nptl/tst-attr3.c
+++ b/nptl/tst-attr3.c
@@ -26,6 +26,7 @@
#include <unistd.h>
#include <stackinfo.h>
+#include <libc-diag.h>
static void *
tf (void *arg)
@@ -362,7 +363,16 @@ do_test (void)
result = 1;
}
+ DIAG_PUSH_NEEDS_COMMENT;
+#if __GNUC_PREREQ (7, 0)
+ /* GCC 8 warns about aliasing of the restrict-qualified arguments
+ passed &a. Since pthread_create does not dereference its fourth
+ argument, this aliasing, which is deliberate in this test, cannot
+ in fact cause problems. */
+ DIAG_IGNORE_NEEDS_COMMENT (8, "-Wrestrict");
+#endif
err = pthread_create (&th, &a, tf, &a);
+ DIAG_POP_NEEDS_COMMENT;
if (err)
{
error (0, err, "pthread_create #2 failed");
@@ -388,7 +398,16 @@ do_test (void)
result = 1;
}
+ DIAG_PUSH_NEEDS_COMMENT;
+#if __GNUC_PREREQ (7, 0)
+ /* GCC 8 warns about aliasing of the restrict-qualified arguments
+ passed &a. Since pthread_create does not dereference its fourth
+ argument, this aliasing, which is deliberate in this test, cannot
+ in fact cause problems. */
+ DIAG_IGNORE_NEEDS_COMMENT (8, "-Wrestrict");
+#endif
err = pthread_create (&th, &a, tf, &a);
+ DIAG_POP_NEEDS_COMMENT;
if (err)
{
error (0, err, "pthread_create #3 failed");