aboutsummaryrefslogtreecommitdiff
path: root/math
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2014-05-14 12:35:40 +0000
committerJoseph Myers <joseph@codesourcery.com>2014-05-14 12:35:40 +0000
commit913d03c864ea2547e97f8d2d30fc71a008d4d103 (patch)
treef5b230d8c416181ef9998a5cf497d7cd89091b72 /math
parent0bf061d3e37e0f72c2378cbded67c58df4f58a4b (diff)
downloadglibc-913d03c864ea2547e97f8d2d30fc71a008d4d103.zip
glibc-913d03c864ea2547e97f8d2d30fc71a008d4d103.tar.gz
glibc-913d03c864ea2547e97f8d2d30fc71a008d4d103.tar.bz2
Fix acosh (1) in round-downward mode (bug 16927).
According to C99 and C11 Annex F, acosh (1) should be +0 in all rounding modes. However, some implementations in glibc wrongly return -0 in round-downward mode (which is what you get if you end up computing log1p (-0), via 1 - 1 being -0 in round-downward mode). This patch fixes the problem implementations, by correcting the test for an exact 1 value in the ldbl-96 implementation to allow for the explicit high bit of the mantissa, and by inserting fabs instructions in the i386 implementations; tests of acosh are duly converted to ALL_RM_TEST. I believe all the other sysdeps/ieee754 implementations are already OK (I haven't checked the ia64 versions, but if buggy then that will be obvious from the results of test runs after this patch is in). Tested x86_64 and x86 and ulps updated accordingly. [BZ #16927] * sysdeps/i386/fpu/e_acosh.S (__ieee754_acosh): Use fabs on x-1 value. * sysdeps/i386/fpu/e_acoshf.S (__ieee754_acoshf): Likewise. * sysdeps/i386/fpu/e_acoshl.S (__ieee754_acoshl): Likewise. * sysdeps/ieee754/ldbl-96/e_acoshl.c (__ieee754_acoshl): Correct for explicit high bit of mantissa when testing for argument equal to 1. * math/libm-test.inc (acosh_test): Use ALL_RM_TEST. * sysdeps/i386/fpu/libm-test-ulps: Update. * sysdeps/x86_64/fpu/libm-test-ulps: Likewise.
Diffstat (limited to 'math')
-rw-r--r--math/libm-test.inc4
1 files changed, 1 insertions, 3 deletions
diff --git a/math/libm-test.inc b/math/libm-test.inc
index a4bf0b8..b4177e8 100644
--- a/math/libm-test.inc
+++ b/math/libm-test.inc
@@ -1792,9 +1792,7 @@ static const struct test_f_f_data acosh_test_data[] =
static void
acosh_test (void)
{
- START (acosh, 0);
- RUN_TEST_LOOP_f_f (acosh, acosh_test_data, );
- END;
+ ALL_RM_TEST (acosh, 0, acosh_test_data, RUN_TEST_LOOP_f_f, END);
}
static const struct test_f_f_data asin_test_data[] =