diff options
| author | Szabolcs Nagy <szabolcs.nagy@arm.com> | 2017-07-04 16:05:12 +0100 |
|---|---|---|
| committer | Szabolcs Nagy <szabolcs.nagy@arm.com> | 2017-07-04 16:05:12 +0100 |
| commit | d2e04918833d90bae7fe5410bb70a045bbd2b64d (patch) | |
| tree | 19bb304474eb148611f811ad8b80848a4d993e77 /libio/libioP.h | |
| parent | 1ff6c67a252e59488a26e3c8f6690b29ef56e369 (diff) | |
| download | glibc-d2e04918833d90bae7fe5410bb70a045bbd2b64d.zip glibc-d2e04918833d90bae7fe5410bb70a045bbd2b64d.tar.gz glibc-d2e04918833d90bae7fe5410bb70a045bbd2b64d.tar.bz2 | |
Single threaded stdio optimization
Locking overhead can be significant in some stdio operations
that are common in single threaded applications.
This patch adds the _IO_FLAGS2_NEED_LOCK flag to indicate if
an _IO_FILE object needs to be locked and some of the stdio
functions just jump to their _unlocked variant when not. The
flag is set on all _IO_FILE objects when the first thread is
created. A new GLIBC_PRIVATE libc symbol, _IO_enable_locks,
was added to do this from libpthread.
The optimization can be applied to more stdio functions,
currently it is only applied to single flag check or single
non-wide-char standard operations. The flag should probably
be never set for files with _IO_USER_LOCK, but that's just a
further optimization, not a correctness requirement.
The optimization is valid in a single thread because stdio
operations are non-as-safe (so lock state is not observable
from a signal handler) and stdio locks are recursive (so lock
state is not observable via deadlock). The optimization is not
valid if a thread may be created while an stdio lock is taken
and thus it should be disabled if any user code may run during
an stdio operation (interposed malloc, printf hooks, etc).
This makes the optimization more complicated for some stdio
operations (e.g. printf), but those are bigger and thus less
important to optimize so this patch does not try to do that.
* libio/libio.h (_IO_FLAGS2_NEED_LOCK, _IO_need_lock): Define.
* libio/libioP.h (_IO_enable_locks): Declare.
* libio/Versions (_IO_enable_locks): New symbol.
* libio/genops.c (_IO_enable_locks): Define.
(_IO_old_init): Initialize flags2.
* libio/feof.c.c (_IO_feof): Avoid locking when not needed.
* libio/ferror.c (_IO_ferror): Likewise.
* libio/fputc.c (fputc): Likewise.
* libio/putc.c (_IO_putc): Likewise.
* libio/getc.c (_IO_getc): Likewise.
* libio/getchar.c (getchar): Likewise.
* libio/ioungetc.c (_IO_ungetc): Likewise.
* nptl/pthread_create.c (__pthread_create_2_1): Enable stdio locks.
* libio/iofopncook.c (_IO_fopencookie): Enable locking for the file.
* sysdeps/pthread/flockfile.c (__flockfile): Likewise.
Diffstat (limited to 'libio/libioP.h')
| -rw-r--r-- | libio/libioP.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/libio/libioP.h b/libio/libioP.h index eb93418..1832b44 100644 --- a/libio/libioP.h +++ b/libio/libioP.h @@ -444,6 +444,8 @@ extern void _IO_list_unlock (void) __THROW; libc_hidden_proto (_IO_list_unlock) extern void _IO_list_resetlock (void) __THROW; libc_hidden_proto (_IO_list_resetlock) +extern void _IO_enable_locks (void) __THROW; +libc_hidden_proto (_IO_enable_locks) /* Default jumptable functions. */ |