aboutsummaryrefslogtreecommitdiff
path: root/io
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2015-10-15 22:29:06 +0000
committerJoseph Myers <joseph@codesourcery.com>2015-10-15 22:29:06 +0000
commitcf1455657ec916ecd78c9d2c3bcbbf6608e6c158 (patch)
tree1d4531f5a4a24d528219dd68e4a93ecd1ec7e184 /io
parentfadd2ad9cc36115440d50b0eae9299e65988917d (diff)
downloadglibc-cf1455657ec916ecd78c9d2c3bcbbf6608e6c158.zip
glibc-cf1455657ec916ecd78c9d2c3bcbbf6608e6c158.tar.gz
glibc-cf1455657ec916ecd78c9d2c3bcbbf6608e6c158.tar.bz2
Do not leave files behind in /tmp from testing.
I noticed that glibc testsuite runs left several files behind in /tmp (or TMPDIR, if different). The problem was testcases that generate a template for mkstemp / mkstemp64, ending with XXXXXX, then pass that template to add_temp_file before calling mkstemp / mkstemp64, meaning that the template ending with XXXXXX is stored in the list of temporary files to delete (add_temp_file uses strdup so that the original string doesn't need to stay live), not the actual filename as determined by mkstemp / mkstemp64. This patch fixes those tests to call add_temp_file later. Tested for x86_64 (that the files are no longer left behind by a testsuite run and the modified tests still pass). * io/test-lfs.c (do_prepare): Do not call add_temp_file until after mkstemp64. * login/tst-utmp.c (do_prepare): Likewise. * rt/tst-aio.c (do_prepare): Likewise. * rt/tst-aio64.c (do_prepare): Likewise.
Diffstat (limited to 'io')
-rw-r--r--io/test-lfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/io/test-lfs.c b/io/test-lfs.c
index b6ebae4..09310a4 100644
--- a/io/test-lfs.c
+++ b/io/test-lfs.c
@@ -56,7 +56,6 @@ do_prepare (int argc, char *argv[])
name = malloc (name_len + sizeof ("/lfsXXXXXX"));
mempcpy (mempcpy (name, test_dir, name_len),
"/lfsXXXXXX", sizeof ("/lfsXXXXXX"));
- add_temp_file (name);
/* Open our test file. */
fd = mkstemp64 (name);
@@ -71,6 +70,7 @@ do_prepare (int argc, char *argv[])
else
error (EXIT_FAILURE, errno, "cannot create temporary file");
}
+ add_temp_file (name);
if (getrlimit64 (RLIMIT_FSIZE, &rlim) != 0)
{