diff options
| author | Martin Sebor <msebor@redhat.com> | 2020-05-11 11:29:39 -0600 |
|---|---|---|
| committer | Martin Sebor <msebor@redhat.com> | 2020-05-11 11:38:02 -0600 |
| commit | 978e8ac39f8ba2d694031e521511da1ae803ccfc (patch) | |
| tree | 0c04918e10ce1632476d991bf3f3a07b6567b90d /io | |
| parent | e627106266ad8785457fadbf5bf67ed604d2a353 (diff) | |
| download | glibc-978e8ac39f8ba2d694031e521511da1ae803ccfc.zip glibc-978e8ac39f8ba2d694031e521511da1ae803ccfc.tar.gz glibc-978e8ac39f8ba2d694031e521511da1ae803ccfc.tar.bz2 | |
Suppress GCC 10 true positive warnings [BZ #25967]
Suppress or avoid warnings in tests that exercise failure modes by making
calls with invalid arguments.
Reviewed-by: DJ Delorie <dj@redhat.com>
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Reviewed-by: Joseph Myers <joseph@codesourcery.com>
Diffstat (limited to 'io')
| -rw-r--r-- | io/tst-getcwd.c | 21 |
1 files changed, 19 insertions, 2 deletions
diff --git a/io/tst-getcwd.c b/io/tst-getcwd.c index 75ecd2c..c9c4713 100644 --- a/io/tst-getcwd.c +++ b/io/tst-getcwd.c @@ -23,6 +23,7 @@ #include <string.h> #include <unistd.h> #include <sys/param.h> +#include <libc-diag.h> #define TEST_FUNCTION do_test () @@ -58,7 +59,13 @@ do_test (void) bufs[i] = (char *) malloc (sbs); } + /* Avoid warnings about the first argument being null when the second + is nonzero. */ + DIAG_PUSH_NEEDS_COMMENT; + DIAG_IGNORE_NEEDS_COMMENT (10.1, "-Wnonnull"); bufs[i] = getcwd (NULL, sbs); + DIAG_POP_NEEDS_COMMENT; + lens[i] = sbs; if (bufs[i] == NULL) { @@ -96,12 +103,17 @@ getcwd (NULL, sbs) = \"%s\", getcwd (thepath, sizeof thepath) = \"%s\"\n", free (bufs[i]); /* Test whether the function signals success despite the buffer - being too small. */ + being too small. + Avoid warnings about the first argument being null when the second + is nonzero. */ + DIAG_PUSH_NEEDS_COMMENT; + DIAG_IGNORE_NEEDS_COMMENT (10.1, "-Wnonnull"); if (getcwd (NULL, len) != NULL) { puts ("getcwd (NULL, len) didn't failed"); return 1; } + DIAG_POP_NEEDS_COMMENT; bufs[0] = malloc (len); bufs[1] = malloc (len); @@ -132,13 +144,18 @@ getcwd (NULL, sbs) = \"%s\", getcwd (thepath, sizeof thepath) = \"%s\"\n", return 1; } - /* Now test handling of correctly sized buffers. */ + /* Now test handling of correctly sized buffers. + Again. avoid warnings about the first argument being null when + the second is nonzero. */ + DIAG_PUSH_NEEDS_COMMENT; + DIAG_IGNORE_NEEDS_COMMENT (10.1, "-Wnonnull"); bufs[0] = getcwd (NULL, len + 1); if (bufs[0] == NULL) { puts ("getcwd (NULL, len + 1) failed"); return 1; } + DIAG_POP_NEEDS_COMMENT; free (bufs[0]); memset (thepath, '\xff', sizeof thepath); |