diff options
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2023-11-10 10:43:12 -0300 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2023-11-16 11:01:51 -0300 |
| commit | a8dcffb30680d6db5704f9ce2fc30621ceb454e7 (patch) | |
| tree | bcac86f64fb7b6a3805a84f6481df67007d7f697 /elf/Makefile | |
| parent | 3fddfe3c5d3c61f91401393814f7dc33be9c7dd3 (diff) | |
| download | glibc-a8dcffb30680d6db5704f9ce2fc30621ceb454e7.zip glibc-a8dcffb30680d6db5704f9ce2fc30621ceb454e7.tar.gz glibc-a8dcffb30680d6db5704f9ce2fc30621ceb454e7.tar.bz2 | |
elf: Handle non-directory name in search path (BZ 31035)
The open_path stops if a relative path in search path contains a
component that is a non directory (for instance, if the component
is an existing file).
For instance:
$ cat > lib.c <<EOF
> void foo (void) {}
> EOF
$ gcc -shared -fPIC -o lib.so lib.c
$ cat > main.c <<EOF
extern void foo ();
int main () { foo (); return 0; }
EOF
$ gcc -o main main.c lib.so
$ LD_LIBRARY_PATH=. ./main
$ LD_LIBRARY_PATH=non-existing/path:. ./main
$ LD_LIBRARY_PATH=$(pwd)/main:. ./main
$ LD_LIBRARY_PATH=./main:. ./main
./main: error while loading shared libraries: lib.so: cannot open shared object file: No such file or directory
The invalid './main' should be ignored as a non-existent one,
instead as a valid but non accessible file.
Absolute paths do not trigger this issue because their status are
initialized as 'unknown' and open_path check if this is a directory.
Checked on x86_64-linux-gnu.
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
Diffstat (limited to 'elf/Makefile')
| -rw-r--r-- | elf/Makefile | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/elf/Makefile b/elf/Makefile index c1e9038..85ce003 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -428,6 +428,7 @@ tests += \ tst-nodelete-opened \ tst-nodelete2 \ tst-noload \ + tst-non-directory-path \ tst-null-argv \ tst-p_align1 \ tst-p_align2 \ @@ -856,6 +857,7 @@ modules-names += \ tst-nodelete-dlclose-plugin \ tst-nodelete-opened-lib \ tst-nodelete2mod \ + tst-non-directory-mod \ tst-null-argv-lib \ tst-p_alignmod-base \ tst-p_alignmod3 \ @@ -1122,6 +1124,7 @@ ifeq (yes,$(build-shared)) ifeq ($(run-built-tests),yes) tests-special += \ $(objpfx)argv0test.out \ + $(objpfx)tst-non-directory-path.out \ $(objpfx)tst-pathopt.out \ $(objpfx)tst-rtld-help.out \ $(objpfx)tst-rtld-list-diagnostics.out \ @@ -2987,3 +2990,12 @@ $(objpfx)tst-decorate-maps: $(shared-thread-library) tst-decorate-maps-ENV = \ GLIBC_TUNABLES=glibc.malloc.arena_max=8:glibc.malloc.mmap_threshold=1024:glibc.mem.decorate_maps=1 tst-decorate-maps-ARGS = 8 + +LDFLAGS-tst-non-directory-mod.so = -Wl,-soname,tst-non-directory-mod.so +$(objpfx)tst-non-directory-path: $(objpfx)tst-non-directory-mod.so +$(objpfx)tst-non-directory-path.out: tst-non-directory-path.sh \ + $(objpfx)tst-non-directory-path + $(SHELL) tst-non-directory-path.sh $(objpfx)ld.so $(objpfx)tst-non-directory-path \ + '$(test-wrapper-env)' '$(run_program_env)' \ + '$(rpath-link)' $(objpfx) > $@; \ + $(evaluate-test) |