diff options
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2017-09-04 16:22:28 -0300 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2017-09-08 15:51:25 +0200 |
| commit | 5554304f0dddf75dc27cc6250fc53355161fd16a (patch) | |
| tree | 4a11cc89f3a5e1d6920b84aadb619010ef3f759e /ChangeLog | |
| parent | 686f2ea18374a541d203cfcc0e1dfba1666f49c2 (diff) | |
| download | glibc-5554304f0dddf75dc27cc6250fc53355161fd16a.zip glibc-5554304f0dddf75dc27cc6250fc53355161fd16a.tar.gz glibc-5554304f0dddf75dc27cc6250fc53355161fd16a.tar.bz2 | |
posix: Allow glob to match dangling symlinks [BZ #866]
This patch makes glob match dangling symlinks. Compared to other glob
implementation (*BSD, bash, musl, and other shells as well), GLIBC seems
the be the only one that does not match dangling symlinks. As for
comment #5 in BZ #866, POSIX does not have any strict specification for
dangling symlinks match and it is reasonable that trying to glob everything
in a path should return all types of files (such as for a 'rm *'). Also,
comment #7 shows even more example where GLIBC current behavior is
unexepected.
I avoided adding another GNU specific flag to set this behavior and
instead make it the default. Although this change the semanthic from
previous implementation, I think adding another compat symbol to be
really unecessary as from aforementioned reasons (current behavior not
defined in any standard, general idea of different implementation is
to list dangling symbols).
This also sync glob with gnulib commit fd1daf4 (glob: match dangling
symlinks).
Checked on x86_64-linux-gnu and on a build using build-many-glibcs.py
for all major architectures.
[BZ #866]
[BZ #1062]
* posix/Makefile (tests): Remove bug-glob1 and tst-glob_symlinks.
* posix/bug-glob1.c: Remove file.
* posix/tst-glob_symlinks.c: New file.
* posix/glob.c (__lstat64): New macro.
(is_dir): New function.
(glob, glob_in_dir): Match symlinks even if they are dangling.
(link_stat, link_exists_p): Remove. All uses removed.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 10 |
1 files changed, 10 insertions, 0 deletions
@@ -1,5 +1,15 @@ 2017-09-08 Adhemerval Zanella <adhemerval.zanella@linaro.org> + [BZ #866] + [BZ #1062] + * posix/Makefile (tests): Remove bug-glob1 and tst-glob_symlinks. + * posix/bug-glob1.c: Remove file. + * posix/tst-glob_symlinks.c: New file. + * posix/glob.c (__lstat64): New macro. + (is_dir): New function. + (glob, glob_in_dir): Match symlinks even if they are dangling. + (link_stat, link_exists_p): Remove. All uses removed. + [BZ #1062] [BZ #19971] * posix/glob.c (struct readdir_result): Remove skip_entry member. |