diff options
| author | Siddhesh Poyarekar <siddhesh@redhat.com> | 2014-03-03 22:51:39 +0530 |
|---|---|---|
| committer | Siddhesh Poyarekar <siddhesh@redhat.com> | 2014-03-03 23:18:31 +0530 |
| commit | 532a60357ef4c5852cc1bf836cfd9d6f093ef204 (patch) | |
| tree | aaeea80df876694911a2058beec5a8004acebe78 /ChangeLog | |
| parent | d6285c9f0b3972369356554727b1ede5a6eb0731 (diff) | |
| download | glibc-532a60357ef4c5852cc1bf836cfd9d6f093ef204.zip glibc-532a60357ef4c5852cc1bf836cfd9d6f093ef204.tar.gz glibc-532a60357ef4c5852cc1bf836cfd9d6f093ef204.tar.bz2 | |
nscd: Improved support for tracking startup failure in nscd service (BZ #16639)
Currently, the nscd parent process parses commandline options and
configuration, forks on startup and immediately exits with a success.
If the child process encounters some error after this, it goes
undetected and any services started up after it may have to repeatedly
check to make sure that the nscd service did actually start up and is
serving requests.
To make this process more reliable, I have added a pipe between the
parent and child process, through which the child process sends a
notification to the parent informing it of its status. The parent
waits for this status and once it receives it, exits with the
corresponding exit code. So if the child service sends a success
status (0), the parent exits with a success status. Similarly for
error conditions, the child sends the non-zero status code, which the
parent passes on as the exit code.
This, along with setting the nscd service type to forking in its
systemd configuration file, allows systemd to be certain that the nscd
service is ready and is accepting connections.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 22 |
1 files changed, 22 insertions, 0 deletions
@@ -1,3 +1,25 @@ +2014-03-03 Siddhesh Poyarekar <siddhesh@redhat.com> + + [BZ #16639] + * nscd/connections.c (nscd_init): Call do_exit. + (start_threads): Call do_exit and notify_parent. + (begin_drop_privileges): Call do_exit. + (finish_drop_privileges): Likewise. + * nscd/selinux.c (preserve_capabilities): Likewise. + (install_real_capabilities): Likewise. + (nscd_selinux_enabled): Likewise. + (avc_create_thread): Likewise. + (avc_alloc_lock): Likewise. + (nscd_avc_init): Likewise. + * nscd/nscd.c (parent_fd): New static variable. + (main): Create a pipe between parent and child processes. + Skip closing parent_fd. + (monitor_child): New function. + (do_exit): Likewise. + (notify_parent): Likewise. + * nscd/nscd.h (notify_parent): Likewise. + (do_exit): Likewise. + 2014-03-03 Carlos O'Donell <carlos@redhat.com> * malloc/malloc.c (__libc_calloc): Revert last change. |