aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Weimer <fweimer@redhat.com>2018-04-09 10:08:07 +0200
committerFangrui Song <i@maskray.me>2021-08-27 16:22:11 -0700
commit43092e2ec2adb9bf76e0456f2b54fe73768fb056 (patch)
tree50519bc8a5cac55939cbdd1587d5691a1b8eda2f
parentadb65ebdcda71510e1fd79cbeacecb6bfb36f6ae (diff)
downloadglibc-43092e2ec2adb9bf76e0456f2b54fe73768fb056.zip
glibc-43092e2ec2adb9bf76e0456f2b54fe73768fb056.tar.gz
glibc-43092e2ec2adb9bf76e0456f2b54fe73768fb056.tar.bz2
resolv: Fully initialize struct mmsghdr in send_dg [BZ #23037]
(cherry picked from commit 583a27d525ae189bdfaa6784021b92a9a1dae12e)
-rw-r--r--ChangeLog6
-rw-r--r--resolv/res_send.c40
2 files changed, 27 insertions, 19 deletions
diff --git a/ChangeLog b/ChangeLog
index 2775346..2a080bd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2018-04-09 Florian Weimer <fweimer@redhat.com>
+
+ [BZ #23037]
+ * resolv/res_send.c (send_dg): Use designated initializers instead
+ of assignment to zero-initialize other fields of struct mmsghdr.
+
2018-04-06 Andreas Schwab <schwab@linux-m68k.org>
* manual/charset.texi (Converting a Character): Fix typo.
diff --git a/resolv/res_send.c b/resolv/res_send.c
index 7debf14..9e95417 100644
--- a/resolv/res_send.c
+++ b/resolv/res_send.c
@@ -1157,25 +1157,27 @@ send_dg(res_state statp,
if (have_sendmmsg >= 0 && nwritten == 0 && buf2 != NULL
&& !single_request)
{
- struct iovec iov[2];
- struct mmsghdr reqs[2];
- reqs[0].msg_hdr.msg_name = NULL;
- reqs[0].msg_hdr.msg_namelen = 0;
- reqs[0].msg_hdr.msg_iov = &iov[0];
- reqs[0].msg_hdr.msg_iovlen = 1;
- iov[0].iov_base = (void *) buf;
- iov[0].iov_len = buflen;
- reqs[0].msg_hdr.msg_control = NULL;
- reqs[0].msg_hdr.msg_controllen = 0;
-
- reqs[1].msg_hdr.msg_name = NULL;
- reqs[1].msg_hdr.msg_namelen = 0;
- reqs[1].msg_hdr.msg_iov = &iov[1];
- reqs[1].msg_hdr.msg_iovlen = 1;
- iov[1].iov_base = (void *) buf2;
- iov[1].iov_len = buflen2;
- reqs[1].msg_hdr.msg_control = NULL;
- reqs[1].msg_hdr.msg_controllen = 0;
+ struct iovec iov =
+ { .iov_base = (void *) buf, .iov_len = buflen };
+ struct iovec iov2 =
+ { .iov_base = (void *) buf2, .iov_len = buflen2 };
+ struct mmsghdr reqs[2] =
+ {
+ {
+ .msg_hdr =
+ {
+ .msg_iov = &iov,
+ .msg_iovlen = 1,
+ },
+ },
+ {
+ .msg_hdr =
+ {
+ .msg_iov = &iov2,
+ .msg_iovlen = 1,
+ }
+ },
+ };
int ndg = __sendmmsg (pfd[0].fd, reqs, 2, MSG_NOSIGNAL);
if (__glibc_likely (ndg == 2))