aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2017-10-24 00:33:08 +0000
committerJoseph Myers <joseph@codesourcery.com>2017-10-24 00:33:08 +0000
commit91c3985c237ba6b2ab2ba20c6d29a38542378864 (patch)
treeb045491c51158aaf6e7e6d0ecc3898dfea10b312
parentaa95a2414e4f664ca740ad5f4a72d9145abbd426 (diff)
downloadglibc-91c3985c237ba6b2ab2ba20c6d29a38542378864.zip
glibc-91c3985c237ba6b2ab2ba20c6d29a38542378864.tar.gz
glibc-91c3985c237ba6b2ab2ba20c6d29a38542378864.tar.bz2
Update x86 fix-fp-int-compare-invalid.h for GCC 8.
The glibc implementation of iseqsig relies on ordered comparison operators raising the "invalid" exception for quiet NaN operands, with a workaround on platforms where a GCC bug means that exception is not raised. For x86, that bug has now been fixed for GCC 8, so this patch disables the workaround in that case. If and when the corresponding bugs for powerpc and s390 are fixed, the headers for those platforms should of course be updated similarly. Tested for x86_64 and x86, including with GCC mainline. Note that other failures appear with GCC mainline because of spurious use of ordered comparison instructions for unordered operations <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82692>. * sysdeps/x86/fpu/fix-fp-int-compare-invalid.h (FIX_COMPARE_INVALID): Define to 0 if [__GNUC_PREREQ (8, 0)].
-rw-r--r--ChangeLog5
-rw-r--r--sysdeps/x86/fpu/fix-fp-int-compare-invalid.h8
2 files changed, 11 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 4448c3d..265524f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2017-10-24 Joseph Myers <joseph@codesourcery.com>
+
+ * sysdeps/x86/fpu/fix-fp-int-compare-invalid.h
+ (FIX_COMPARE_INVALID): Define to 0 if [__GNUC_PREREQ (8, 0)].
+
2017-10-23 Adhemerval Zanella <adhemerval.zanella@linaro.org>
* sysdeps/unix/sysv/linux/spawni.c (__spawnix): Use 0 instead of
diff --git a/sysdeps/x86/fpu/fix-fp-int-compare-invalid.h b/sysdeps/x86/fpu/fix-fp-int-compare-invalid.h
index bda247d..842c945 100644
--- a/sysdeps/x86/fpu/fix-fp-int-compare-invalid.h
+++ b/sysdeps/x86/fpu/fix-fp-int-compare-invalid.h
@@ -20,9 +20,13 @@
#ifndef FIX_FP_INT_COMPARE_INVALID_H
#define FIX_FP_INT_COMPARE_INVALID_H 1
-/* As of GCC 5, both x87 and SSE comparisons use unordered comparison
+/* Before GCC 8, both x87 and SSE comparisons use unordered comparison
instructions when they should use ordered comparisons
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52451>. */
-#define FIX_COMPARE_INVALID 1
+#if __GNUC_PREREQ (8, 0)
+# define FIX_COMPARE_INVALID 0
+#else
+# define FIX_COMPARE_INVALID 1
+#endif
#endif /* fix-fp-int-compare-invalid.h */