aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2017-05-18 14:02:02 -0700
committerH.J. Lu <hjl.tools@gmail.com>2017-05-18 14:02:02 -0700
commita7fbedff76494b5b694f647e9c681cf8988056ce (patch)
tree9a5a4855137419b9e3e5985c1e95ffb875133cb6
parentce79740bdbccea312df6cfcf70689efb57792fc9 (diff)
downloadglibc-a7fbedff76494b5b694f647e9c681cf8988056ce.zip
glibc-a7fbedff76494b5b694f647e9c681cf8988056ce.tar.gz
glibc-a7fbedff76494b5b694f647e9c681cf8988056ce.tar.bz2
Correct comments in x86_64/multiarch/memcmp.S
* sysdeps/x86_64/multiarch/memcmp.S (__GI_memcmp): Correct comments.
-rw-r--r--ChangeLog5
-rw-r--r--sysdeps/x86_64/multiarch/memcmp.S6
2 files changed, 8 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog
index 06ef578..5ebd3a0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2017-05-18 H.J. Lu <hongjiu.lu@intel.com>
+
+ * sysdeps/x86_64/multiarch/memcmp.S (__GI_memcmp): Correct
+ comments.
+
2017-05-18 Siddhesh Poyarekar <siddhesh@sourceware.org>
* elf/Makefile (tst-env-setuid-ENV): Reduce value of
diff --git a/sysdeps/x86_64/multiarch/memcmp.S b/sysdeps/x86_64/multiarch/memcmp.S
index 8262317..6129820 100644
--- a/sysdeps/x86_64/multiarch/memcmp.S
+++ b/sysdeps/x86_64/multiarch/memcmp.S
@@ -56,9 +56,9 @@ END(memcmp)
# ifdef SHARED
# undef libc_hidden_builtin_def
-/* IFUNC doesn't work with the hidden functions in shared library since
- they will be called without setting up EBX needed for PLT which is
- used by IFUNC. */
+/* It doesn't make sense to send libc-internal memcmp calls through a PLT.
+ The speedup we get from using SSE4 instructions is likely eaten away
+ by the indirect call in the PLT. */
# define libc_hidden_builtin_def(name) \
.globl __GI_memcmp; __GI_memcmp = __memcmp_sse2
# endif