diff options
| author | Stafford Horne <shorne@gmail.com> | 2021-09-25 17:02:06 +0900 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2021-09-28 10:47:08 -0300 |
| commit | 9874ca536b1d0662b1cea46af3ce09a4d42aeb32 (patch) | |
| tree | 7639bf0d462ca6a56b751465e1b21112cf1aea12 | |
| parent | 8e2557a2b85b2eb0ed50a9016a4ffc6b859b97e6 (diff) | |
| download | glibc-9874ca536b1d0662b1cea46af3ce09a4d42aeb32.zip glibc-9874ca536b1d0662b1cea46af3ce09a4d42aeb32.tar.gz glibc-9874ca536b1d0662b1cea46af3ce09a4d42aeb32.tar.bz2 | |
pthread/tst-cancel28: Fix barrier re-init race condition
When running this test on the OpenRISC port I am working on this test
fails with a timeout. The test passes when being straced or debugged.
Looking at the code there seems to be a race condition in that:
1 main thread: calls xpthread_cancel
2 sub thread : receives cancel signal
3 sub thread : cleanup routine waits on barrier
4 main thread: re-inits barrier
5 main thread: waits on barrier
After getting to 5 the main thread and sub thread wait forever as the 2
barriers are no longer the same.
Removing the barrier re-init seems to fix this issue. Also, the barrier
does not need to be reinitialized as that is done by default.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
| -rw-r--r-- | sysdeps/pthread/tst-cancel28.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sysdeps/pthread/tst-cancel28.c b/sysdeps/pthread/tst-cancel28.c index 627cbc8..9286c15 100644 --- a/sysdeps/pthread/tst-cancel28.c +++ b/sysdeps/pthread/tst-cancel28.c @@ -69,7 +69,6 @@ do_test (void) xpthread_cancel (timer_thread); - xpthread_barrier_init (&barrier, NULL, 2); xpthread_barrier_wait (&barrier); return 0; |