diff options
| author | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2024-06-10 21:57:53 +0200 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2024-06-10 21:57:53 +0200 |
| commit | ba5a23422a156804234dff6c5be89e20ee8f9ec2 (patch) | |
| tree | fb3a7ac05460b0b8511dedb802d7b6c82edc8249 | |
| parent | 74f9ee3b91931967df5601ad63a4b02f5cd75b43 (diff) | |
| download | glibc-ba5a23422a156804234dff6c5be89e20ee8f9ec2.zip glibc-ba5a23422a156804234dff6c5be89e20ee8f9ec2.tar.gz glibc-ba5a23422a156804234dff6c5be89e20ee8f9ec2.tar.bz2 | |
hurd: Fix getxattr("gnu.translator") returning ENODATA
When no translator is set, __file_get_translator would return EINVAL
which is a confusing value. Better check for a passive translation
before getting the value.
| -rw-r--r-- | hurd/xattr.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/hurd/xattr.c b/hurd/xattr.c index 0715ad7..f613d47 100644 --- a/hurd/xattr.c +++ b/hurd/xattr.c @@ -61,7 +61,16 @@ _hurd_xattr_get (io_t port, const char *name, void *value, size_t *size) { char *buf = value; mach_msg_type_number_t bufsz = value ? *size : 0; - error_t err = __file_get_translator (port, &buf, &bufsz); + struct stat64 st; + error_t err; + + err = __io_stat (port, &st); + if (err) + return err; + if ((st.st_mode & S_IPTRANS) == 0) + return ENODATA; + + err = __file_get_translator (port, &buf, &bufsz); if (err) return err; if (value != NULL && *size < bufsz) |