From d47f5b30d8481272e9480118bdcb283690070349 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Sat, 2 Jan 2016 09:23:06 -0500 Subject: sim: delete dead current_state globals The global current_state handle to the current simulator state is a design idea that was half implemented, but never really cleaned up. The point was to have a global variable pointing to the state so that funcs could more quickly & easily access the state anywhere. We've instead moved in the direction of passing state around everywhere and don't have any intention of moving back. I also can't find any references to gdb using this variable, or to cgen related "dump_regs" functions, both of which were used in the comments related to this code. --- sim/sh64/ChangeLog | 5 +++++ sim/sh64/sim-if.c | 8 -------- 2 files changed, 5 insertions(+), 8 deletions(-) (limited to 'sim/sh64') diff --git a/sim/sh64/ChangeLog b/sim/sh64/ChangeLog index 945ec35..06ce139 100644 --- a/sim/sh64/ChangeLog +++ b/sim/sh64/ChangeLog @@ -1,3 +1,8 @@ +2016-01-02 Mike Frysinger + + * sim-if.c (current_state): Delete. + (sim_open): Delete current_state assignment. + 2015-12-27 Mike Frysinger * Makefile.in (SIM_OBJS): Delete sim-hload.o. diff --git a/sim/sh64/sim-if.c b/sim/sh64/sim-if.c index bbc57cd..a74f1e5 100644 --- a/sim/sh64/sim-if.c +++ b/sim/sh64/sim-if.c @@ -32,10 +32,6 @@ static void free_state (SIM_DESC); /* Since we don't build the cgen-opcode table, we use a wrapper around the existing disassembler from libopcodes. */ static CGEN_DISASSEMBLER sh64_disassemble_insn; - -/* Records simulator descriptor so utilities like sh5_dump_regs can be - called from gdb. */ -SIM_DESC current_state; /* Cover function of sim_state_free to free the cpu buffers as well. */ @@ -155,10 +151,6 @@ sim_open (kind, callback, abfd, argv) Must be done after sh_cgen_cpu_open. */ cgen_init (sd); - /* Store in a global so things like sparc32_dump_regs can be invoked - from the gdb command line. */ - current_state = sd; - return sd; } -- cgit v1.1