From ee1cffd3883c1d846ad58c1fb86559bb2f930361 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 31 Oct 2022 21:43:10 +0545 Subject: sim: common: change sim_{fetch,store}_register helpers to use void* buffers When reading/writing arbitrary data to the system's memory, the unsigned char pointer type doesn't make that much sense. Switch it to void so we align a bit with standard C library read/write functions, and to avoid having to sprinkle casts everywhere. --- sim/mips/interp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'sim/mips') diff --git a/sim/mips/interp.c b/sim/mips/interp.c index 5540d5c..ab20f07 100644 --- a/sim/mips/interp.c +++ b/sim/mips/interp.c @@ -336,8 +336,8 @@ mips_pc_set (sim_cpu *cpu, sim_cia pc) PC = pc; } -static int mips_reg_fetch (SIM_CPU *, int, unsigned char *, int); -static int mips_reg_store (SIM_CPU *, int, const unsigned char *, int); +static int mips_reg_fetch (SIM_CPU *, int, void *, int); +static int mips_reg_store (SIM_CPU *, int, const void *, int); SIM_DESC sim_open (SIM_OPEN_KIND kind, host_callback *cb, @@ -846,7 +846,7 @@ mips_sim_close (SIM_DESC sd, int quitting) } static int -mips_reg_store (SIM_CPU *cpu, int rn, const unsigned char *memory, int length) +mips_reg_store (SIM_CPU *cpu, int rn, const void *memory, int length) { /* NOTE: gdb (the client) stores registers in target byte order while the simulator uses host byte order */ @@ -925,7 +925,7 @@ mips_reg_store (SIM_CPU *cpu, int rn, const unsigned char *memory, int length) } static int -mips_reg_fetch (SIM_CPU *cpu, int rn, unsigned char *memory, int length) +mips_reg_fetch (SIM_CPU *cpu, int rn, void *memory, int length) { /* NOTE: gdb (the client) stores registers in target byte order while the simulator uses host byte order */ -- cgit v1.1