From ed3818775569116d7f09df3d81e22cb8169a8c06 Mon Sep 17 00:00:00 2001 From: "Maciej W. Rozycki" Date: Tue, 20 Mar 2018 11:48:59 +0000 Subject: gc.exp: Remove extraneous LD flags from the personality test Complement commit 8988502d7534 ("MIPS/LD/testsuite: Correct dynamic links with VR4100, VR4300 and VR5000") and commit bf48520113c4 ("gc.exp: Fix a typo: $LFLAGS -> $LDFLAGS"), and remove extraneous additional LD flags explicitly passed to the personality test on invocation. This passing has accidentally leaked from a WIP version of the former change. With the actual version committed the $LDFLAGS global variable is used instead for `run_dump_test' to use implicitly, so that `-call_shared' precedes `-lpersonality' on the linker's command line, as otherwise a shared `libpersonality.so' library wouldn't be considered for linking, causing the test to fail. ld/ * testsuite/ld-gc/gc.exp: Remove extraneous LD flags from the personality test. --- ld/ChangeLog | 5 +++++ ld/testsuite/ld-gc/gc.exp | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) (limited to 'ld') diff --git a/ld/ChangeLog b/ld/ChangeLog index 2eaf710..7270ac0 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,8 @@ +2018-03-20 Maciej W. Rozycki + + * testsuite/ld-gc/gc.exp: Remove extraneous LD flags from the + personality test. + 2018-03-20 H.J. Lu PR ld/22983 diff --git a/ld/testsuite/ld-gc/gc.exp b/ld/testsuite/ld-gc/gc.exp index efdddd7..75d5714 100644 --- a/ld/testsuite/ld-gc/gc.exp +++ b/ld/testsuite/ld-gc/gc.exp @@ -127,7 +127,7 @@ if { [is_elf_format] && [check_shared_lib_support] } then { || ![ld_link $ld tmpdir/libpersonality.so "-shared tmpdir/libpersonality.o"] } then { fail libpersonality } else { - run_dump_test "personality" [list [list ld $LDFLAGS]] + run_dump_test "personality" } run_dump_test "pr18223" if {![ld_assemble_flags $as $gasopt $srcdir/$subdir/pr20022a.s tmpdir/pr20022a.o] -- cgit v1.1