From ab7fede88eddf004994f8769e3c7ac145628f5b4 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Tue, 18 Nov 2014 11:03:09 -0800 Subject: Check PC-relative offset overflow in PLT entry This patch checks PC-relative offset overflow in pushq instruction in x86-64 PLT entry. bfd/ PR ld/17618 * elf64-x86-64.c (elf_x86_64_finish_dynamic_symbol): Check PC-relative offset overflow in PLT entry. ld/testsuite/ PR ld/17618 * ld-x86-64/x86-64.exp: Run pr17618 for Linux target. * ld-x86-64/pr17618.d: New file. * ld-x86-64/pr17618.s: Likewise. --- ld/testsuite/ChangeLog | 8 ++++++++ ld/testsuite/ld-x86-64/pr17618.d | 4 ++++ ld/testsuite/ld-x86-64/pr17618.s | 18 ++++++++++++++++++ ld/testsuite/ld-x86-64/x86-64.exp | 7 +++++++ 4 files changed, 37 insertions(+) create mode 100644 ld/testsuite/ld-x86-64/pr17618.d create mode 100644 ld/testsuite/ld-x86-64/pr17618.s (limited to 'ld') diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog index a8aa37d..72b4bb9 100644 --- a/ld/testsuite/ChangeLog +++ b/ld/testsuite/ChangeLog @@ -1,5 +1,13 @@ 2014-11-18 H.J. Lu + PR ld/17618 + * ld-x86-64/x86-64.exp: Run pr17618 for Linux target. + + * ld-x86-64/pr17618.d: New file. + * ld-x86-64/pr17618.s: Likewise. + +2014-11-18 H.J. Lu + * ld-x86-64/mpx.exp: Always run mpx3 and mpx4 tests in 64-bit. 2014-11-18 Igor Zamyatin diff --git a/ld/testsuite/ld-x86-64/pr17618.d b/ld/testsuite/ld-x86-64/pr17618.d new file mode 100644 index 0000000..e640b40 --- /dev/null +++ b/ld/testsuite/ld-x86-64/pr17618.d @@ -0,0 +1,4 @@ +#name: PLT PC-relative offset overflow check +#as: --64 +#ld: -shared -melf_x86_64 +#error: .*PC-relative offset overflow in PLT entry for `bar' diff --git a/ld/testsuite/ld-x86-64/pr17618.s b/ld/testsuite/ld-x86-64/pr17618.s new file mode 100644 index 0000000..39102e0 --- /dev/null +++ b/ld/testsuite/ld-x86-64/pr17618.s @@ -0,0 +1,18 @@ + .text + .globl foo + .type foo, @function +foo: + call bar@PLT + .size foo, .-foo + + .globl gap + .type gap, @function +gap: + jmp .L0 + .space 0x40000000, 0x90 +.L0: + jmp .L2 + .space 0x3fdfff14, 0x90 +.L2: + .size gap, .-gap + .section .note.GNU-stack,"",@progbits diff --git a/ld/testsuite/ld-x86-64/x86-64.exp b/ld/testsuite/ld-x86-64/x86-64.exp index a9b68ff..7f09458 100644 --- a/ld/testsuite/ld-x86-64/x86-64.exp +++ b/ld/testsuite/ld-x86-64/x86-64.exp @@ -333,3 +333,10 @@ if { [isnative] && [which $CC] != 0 } { {dummy.s} {{readelf {-s --wide} x86-64-x32.rd}} "x86-64-x32"} } } + +if { ![istarget "x86_64-*-linux*"]} { + return +} + +# Linux only tests +run_dump_test "pr17618" -- cgit v1.1