From 8efa2874ab298f3923f4127340da119435f87c39 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Thu, 13 Aug 2015 04:31:38 -0700 Subject: Issue an error for read-only segment with dynamic IFUNC relocations To load an ELF binary with DT_TEXTREL tag, the dynamic linker calls __mprotect on the read-only segment with PROT_READ|PROT_WRITE before applying dynamic relocation. It leads to segfault when performing IFUNC relocations since the read-only segment has no execute permission. This patch changes x86 linker to issue an error for read-only segment with dynamic IFUNC relocations. Other backends with IFUNC support may need a similar change. bfd/ PR ld/18801 * elf32-i386.c (elf_i386_size_dynamic_sections): Issue an error for read-only segment with dynamic IFUNC relocations. * elf64-x86-64.c (elf_x86_64_size_dynamic_sections): Likewise. ld/testsuite/ PR ld/18801 * ld-i386/i386.exp: Run pr18801. * ld-x86-64/x86-64.exp: Likewise. * ld-i386/pr18801.d: New file. * ld-i386/pr18801.s: Likewise. * ld-x86-64/pr18801.d: Likewise. * ld-x86-64/pr18801.s: Likewise. --- ld/testsuite/ld-x86-64/pr18801.s | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 ld/testsuite/ld-x86-64/pr18801.s (limited to 'ld/testsuite/ld-x86-64/pr18801.s') diff --git a/ld/testsuite/ld-x86-64/pr18801.s b/ld/testsuite/ld-x86-64/pr18801.s new file mode 100644 index 0000000..16d36da --- /dev/null +++ b/ld/testsuite/ld-x86-64/pr18801.s @@ -0,0 +1,15 @@ + .text + .type selector, %function +foo: + movl $0, %eax + ret +selector: + movabs $foo, %rax + ret + .type selector, %gnu_indirect_function + .globl _start +_start: + movabs $selector, %rax + call *%rax + ret + .section .note.GNU-stack,"",@progbits -- cgit v1.1