From 994b25132814f4c2be93ce53a616a74139c4cf3c Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Sun, 17 Jan 2021 20:01:16 -0800 Subject: ld/elf: Ignore section symbols when matching linkonce with comdat When deciding if a single member comdat group section in file FOO should be discarded by a linkonce section in file BAR, we check if 2 sections define the same set of local and global symbols. When only one of the files doesn't contain the unused section symbols in the symbol table, such as object files generated by clang or GNU assembler with commit d1bcae833b32f1408485ce69f844dcd7ded093a8 Author: H.J. Lu Date: Thu Jan 7 06:42:00 2021 -0800 ELF: Don't generate unused section symbols the check will fail since one file has the extra unused section symbols. We should ignore both undefined and section symbols in the symbol table when making such a decision. bfd/ PR ld/27193 * elflink.c (elf_create_symbuf): Also ignore section symbols. ld/ PR ld/27193 * testsuite/ld-i386/i386.exp: Run PR ld/27193 test. * testsuite/ld-i386/pr27193.dd: New file. * testsuite/ld-i386/pr27193a.o.bz2: Likewise. * testsuite/ld-i386/pr27193b.s: Likewise. --- ld/testsuite/ld-i386/i386.exp | 5 +++++ ld/testsuite/ld-i386/pr27193.dd | 5 +++++ ld/testsuite/ld-i386/pr27193a.o.bz2 | Bin 0 -> 468 bytes ld/testsuite/ld-i386/pr27193b.s | 8 ++++++++ 4 files changed, 18 insertions(+) create mode 100644 ld/testsuite/ld-i386/pr27193.dd create mode 100644 ld/testsuite/ld-i386/pr27193a.o.bz2 create mode 100644 ld/testsuite/ld-i386/pr27193b.s (limited to 'ld/testsuite/ld-i386') diff --git a/ld/testsuite/ld-i386/i386.exp b/ld/testsuite/ld-i386/i386.exp index f3e62a4..0be6b86 100644 --- a/ld/testsuite/ld-i386/i386.exp +++ b/ld/testsuite/ld-i386/i386.exp @@ -245,6 +245,11 @@ set i386tests { "-melf_i386 -shared -Bsymbolic -z notext" "" "--32 -mx86-used-note=yes" { pr19827a.S } {{readelf {-rW} pr19827.rd}} "pr19827.so"} + {"Build pr27193.so" + "-melf_i386 -shared" "" + "--32" + { pr27193a.o.bz2 pr27193b.s } + {{objdump {-dw} pr27193.dd}} "pr27193.so"} } proc iamcu_tests {} { diff --git a/ld/testsuite/ld-i386/pr27193.dd b/ld/testsuite/ld-i386/pr27193.dd new file mode 100644 index 0000000..7d1e799 --- /dev/null +++ b/ld/testsuite/ld-i386/pr27193.dd @@ -0,0 +1,5 @@ +#... +0+[a-f0-9]+ <__x86.get_pc_thunk.bx>: + +[a-f0-9]+: 8b 1c 24 mov \(%esp\),%ebx + +[a-f0-9]+: c3 ret +#pass diff --git a/ld/testsuite/ld-i386/pr27193a.o.bz2 b/ld/testsuite/ld-i386/pr27193a.o.bz2 new file mode 100644 index 0000000..365899d Binary files /dev/null and b/ld/testsuite/ld-i386/pr27193a.o.bz2 differ diff --git a/ld/testsuite/ld-i386/pr27193b.s b/ld/testsuite/ld-i386/pr27193b.s new file mode 100644 index 0000000..9b27a6f --- /dev/null +++ b/ld/testsuite/ld-i386/pr27193b.s @@ -0,0 +1,8 @@ + .section .text.__x86.get_pc_thunk.bx,"axG",%progbits,__x86.get_pc_thunk.bx,comdat + .globl __x86.get_pc_thunk.bx + .hidden __x86.get_pc_thunk.bx + .type __x86.get_pc_thunk.bx, %function + .p2align 4 +__x86.get_pc_thunk.bx: + mov (%esp),%ebx + ret -- cgit v1.1