From 4153b6dbb0f38a16fd5b583761aa811212fbb9a5 Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Tue, 22 Mar 2016 12:25:08 +0000 Subject: Improve COFF/PE linker garbage collection by preventing the removal of sections containing exported symbols. PR ld/19803 * ldlang.c (lang_add_gc_name): New function. Adds the provided symbol name to the list of gc symbols. (lang_process): Call lang_add_gc_name with entry_symbol_default if entry_symbol.name is NULL. Use lang_add_gc_name to add the init and fini function names. * pe-dll.c (process_def_file_and_drectve): Add exported names to the gc symbol list. * testsuite/ld-pe/pr19803.s: Do not export _testval symbol. * testsuite/ld-pe/pr19803.d: Tweak expected output. --- ld/pe-dll.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'ld/pe-dll.c') diff --git a/ld/pe-dll.c b/ld/pe-dll.c index a2792e8..a280647 100644 --- a/ld/pe-dll.c +++ b/ld/pe-dll.c @@ -897,6 +897,9 @@ process_def_file_and_drectve (bfd *abfd ATTRIBUTE_UNUSED, struct bfd_link_info * char *int_name = pe_def_file->exports[i].internal_name; char *name; + /* PR 19803: Make sure that any exported symbol does not get garbage collected. */ + lang_add_gc_name (int_name); + name = xmalloc (strlen (int_name) + 2); if (pe_details->underscored && int_name[0] != '@') { -- cgit v1.1