From caa170493e884215af4d07ea891ed1e2eeeb0578 Mon Sep 17 00:00:00 2001 From: Nick Alcock Date: Wed, 27 Jan 2021 19:55:45 +0000 Subject: libctf: prohibit nameless ints, floats, typedefs and forwards Now that "anonymous typedef nodes" have been extirpated, we can mandate that things that have names in C must have names in CTF too. (Unlike the no-forwards embarrassment, the deduplicator does nothing special with names: types that have names in C will have the same name in CTF. So we can assume that the CTF rules and the C rules are the same.) include/ChangeLog 2021-01-27 Nick Alcock * ctf-api.h (ECTF_NONAME): New. (ECTF_NERR): Adjust. libctf/ChangeLog 2021-01-27 Nick Alcock * ctf-create.c (ctf_add_encoded): Add check for non-empty name. (ctf_add_forward): Likewise. (ctf_add_typedef): Likewise. --- include/ChangeLog | 5 +++++ include/ctf-api.h | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) (limited to 'include') diff --git a/include/ChangeLog b/include/ChangeLog index 163b506..56a9a61 100644 --- a/include/ChangeLog +++ b/include/ChangeLog @@ -1,3 +1,8 @@ +2021-01-27 Nick Alcock + + * ctf-api.h (ECTF_NONAME): New. + (ECTF_NERR): Adjust. + 2021-01-26 Nick Alcock * ctf-api.h (CTF_LINK_NO_FILTER_REPORTED_SYMS): New. diff --git a/include/ctf-api.h b/include/ctf-api.h index 954778a..6dd43aa 100644 --- a/include/ctf-api.h +++ b/include/ctf-api.h @@ -240,7 +240,8 @@ typedef struct ctf_snapshot_id _CTF_ITEM (ECTF_NEXT_WRONGFP, "Iteration entity changed in mid-iterate.") \ _CTF_ITEM (ECTF_FLAGS, "CTF header contains flags unknown to libctf.") \ _CTF_ITEM (ECTF_NEEDSBFD, "This feature needs a libctf with BFD support.") \ - _CTF_ITEM (ECTF_INCOMPLETE, "Type is not a complete type.") + _CTF_ITEM (ECTF_INCOMPLETE, "Type is not a complete type.") \ + _CTF_ITEM (ECTF_NONAME, "Type name must not be empty.") #define ECTF_BASE 1000 /* Base value for libctf errnos. */ @@ -253,7 +254,7 @@ _CTF_ERRORS #undef _CTF_FIRST }; -#define ECTF_NERR (ECTF_INCOMPLETE - ECTF_BASE + 1) /* Count of CTF errors. */ +#define ECTF_NERR (ECTF_NONAME - ECTF_BASE + 1) /* Count of CTF errors. */ /* The CTF data model is inferred to be the caller's data model or the data model of the given object, unless ctf_setmodel is explicitly called. */ -- cgit v1.1