From 8aabe2e254e6a0419db9c6397c4068c69bfd95b0 Mon Sep 17 00:00:00 2001 From: Edjunior Barbosa Machado Date: Wed, 21 Sep 2016 14:47:43 -0300 Subject: ppc: Fix return of instruction handlers in ppc_process_record_op63 some instruction handlers in ppc_process_record_op63() seem to be missing return or incorrectly using break. This patch aims to fix that. gdb/ChangeLog: 2016-09-21 Edjunior Barbosa Machado * rs6000-tdep.c (ppc_process_record_op63): Fix return of instruction handlers. --- gdb/ChangeLog | 5 +++++ gdb/rs6000-tdep.c | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) (limited to 'gdb') diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6753ebe..4ee67fb 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2016-09-21 Edjunior Barbosa Machado + + * rs6000-tdep.c (ppc_process_record_op63): Fix return of instruction + handlers. + 2016-09-21 Tom Tromey PR gdb/20604: diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index d7cf38f..1add498 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -5399,6 +5399,7 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache, tdep->ppc_fp0_regnum + PPC_FRT (insn)); if (PPC_RC (insn)) record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum); + return 0; } switch (ext & 0xff) @@ -5462,7 +5463,7 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache, if (PPC_RC (insn)) record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum); record_full_arch_list_add_reg (regcache, tdep->ppc_fpscr_regnum); - break; + return 0; case 354: /* DFP Extract Biased Exponent Quad */ record_full_arch_list_add_reg (regcache, @@ -5541,7 +5542,7 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache, if (PPC_RC (insn)) record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum); record_full_arch_list_add_reg (regcache, tdep->ppc_fpscr_regnum); - break; + return 0; case 0: /* Floating Compare Unordered */ case 32: /* Floating Compare Ordered */ -- cgit v1.1