From 803c08d083556154cd4d27368e58b359e9de8b93 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 29 Aug 2018 23:03:09 -0600 Subject: Return std::string from gdb_bfd_errmsg This changes gdb_bfd_errmsg to return a std::string, removing a cleanup. This approach may be slightly less efficient than the previous code, but I don't believe this is very important in this situation. gdb/ChangeLog 2018-09-13 Tom Tromey * utils.h (gdb_bfd_errmsg): Return std::string. * exec.c (exec_file_attach): Update. * compile/compile-object-load.c (compile_object_load): Update. * utils.c (gdb_bfd_errmsg): Return std::string. --- gdb/utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gdb/utils.h') diff --git a/gdb/utils.h b/gdb/utils.h index 6852399..fa9a590 100644 --- a/gdb/utils.h +++ b/gdb/utils.h @@ -115,7 +115,7 @@ compare_cstrings (const char *str1, const char *str2) MATCHING, if non-NULL, is the corresponding argument to bfd_check_format_matches, and will be freed. */ -extern const char *gdb_bfd_errmsg (bfd_error_type error_tag, char **matching); +extern std::string gdb_bfd_errmsg (bfd_error_type error_tag, char **matching); /* Reset the prompt_for_continue clock. */ void reset_prompt_for_continue_wait_time (void); -- cgit v1.1