From 6bd434d6caa4c08a5ea87fe327d802c1e00a5c5e Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 20 Jan 2021 20:55:05 -0500 Subject: gdb: make some variables static I'm trying to enable clang's -Wmissing-variable-declarations warning. This patch fixes all the obvious spots where we can simply add "static" (at least, found when building on x86-64 Linux). gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_linux_record_tdep): Make static. * aarch64-tdep.c (tdesc_aarch64_list, aarch64_prologue_unwind, aarch64_stub_unwind, aarch64_normal_base, ): Make static. * arm-linux-tdep.c (arm_prologue_unwind): Make static. * arm-tdep.c (struct frame_unwind): Make static. * auto-load.c (auto_load_safe_path_vec): Make static. * csky-tdep.c (csky_stub_unwind): Make static. * gdbarch.c (gdbarch_data_registry): Make static. * gnu-v2-abi.c (gnu_v2_abi_ops): Make static. * i386-netbsd-tdep.c (i386nbsd_mc_reg_offset): Make static. * i386-tdep.c (i386_frame_setup_skip_insns, i386_tramp_chain_in_reg_insns, i386_tramp_chain_on_stack_insns): Make static. * infrun.c (observer_mode): Make static. * linux-nat.c (sigchld_action): Make static. * linux-thread-db.c (thread_db_list): Make static. * maint-test-options.c (maintenance_test_options_list): * mep-tdep.c (mep_csr_registers): Make static. * mi/mi-cmds.c (struct mi_cmd_stats): Remove struct type name. (stats): Make static. * nat/linux-osdata.c (struct osdata_type): Make static. * ppc-netbsd-tdep.c (ppcnbsd_reg_offsets): Make static. * progspace.c (last_program_space_num): Make static. * python/py-param.c (struct parm_constant): Remove struct type name. (parm_constants): Make static. * python/py-record-btrace.c (btpy_list_methods): Make static. * python/py-record.c (recpy_gap_type): Make static. * record.c (record_goto_cmdlist): Make static. * regcache.c (regcache_descr_handle): Make static. * registry.h (DEFINE_REGISTRY): Make definition static. * symmisc.c (std_in, std_out, std_err): Make static. * top.c (previous_saved_command_line): Make static. * tracepoint.c (trace_user, trace_notes, trace_stop_notes): Make static. * unittests/command-def-selftests.c (nr_duplicates, nr_invalid_prefixcmd, lists): Make static. * unittests/observable-selftests.c (test_notification): Make static. * unittests/optional/assignment/1.cc (counter): Make static. * unittests/optional/assignment/2.cc (counter): Make static. * unittests/optional/assignment/3.cc (counter): Make static. * unittests/optional/assignment/4.cc (counter): Make static. * unittests/optional/assignment/5.cc (counter): Make static. * unittests/optional/assignment/6.cc (counter): Make static. gdbserver/ChangeLog: * ax.cc (bytecode_address_table): Make static. * debug.cc (debug_file): Make static. * linux-low.cc (stopping_threads): Make static. (step_over_bkpt): Make static. * linux-x86-low.cc (amd64_emit_ops, i386_emit_ops): Make static. * tracepoint.cc (stop_tracing_bkpt, flush_trace_buffer_bkpt, alloced_trace_state_variables, trace_buffer_ctrl, tracing_start_time, tracing_stop_time, tracing_user_name, tracing_notes, tracing_stop_note): Make static. Change-Id: Ic1d8034723b7802502bda23770893be2338ab020 --- gdb/unittests/optional/assignment/1.cc | 2 +- gdb/unittests/optional/assignment/2.cc | 2 +- gdb/unittests/optional/assignment/3.cc | 2 +- gdb/unittests/optional/assignment/4.cc | 2 +- gdb/unittests/optional/assignment/5.cc | 2 +- gdb/unittests/optional/assignment/6.cc | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) (limited to 'gdb/unittests/optional') diff --git a/gdb/unittests/optional/assignment/1.cc b/gdb/unittests/optional/assignment/1.cc index f711c4d..80eaa24 100644 --- a/gdb/unittests/optional/assignment/1.cc +++ b/gdb/unittests/optional/assignment/1.cc @@ -19,7 +19,7 @@ namespace assign_1 { struct exception {}; -int counter = 0; +static int counter = 0; struct mixin_counter { diff --git a/gdb/unittests/optional/assignment/2.cc b/gdb/unittests/optional/assignment/2.cc index fdc07f1..85c41c5 100644 --- a/gdb/unittests/optional/assignment/2.cc +++ b/gdb/unittests/optional/assignment/2.cc @@ -19,7 +19,7 @@ namespace assign_2 { struct exception {}; -int counter = 0; +static int counter = 0; struct mixin_counter { diff --git a/gdb/unittests/optional/assignment/3.cc b/gdb/unittests/optional/assignment/3.cc index e479f9c..03f6018 100644 --- a/gdb/unittests/optional/assignment/3.cc +++ b/gdb/unittests/optional/assignment/3.cc @@ -19,7 +19,7 @@ namespace assign_3 { struct exception {}; -int counter = 0; +static int counter = 0; struct mixin_counter { diff --git a/gdb/unittests/optional/assignment/4.cc b/gdb/unittests/optional/assignment/4.cc index 2bfe562..aa04292 100644 --- a/gdb/unittests/optional/assignment/4.cc +++ b/gdb/unittests/optional/assignment/4.cc @@ -19,7 +19,7 @@ namespace assign_4 { struct exception {}; -int counter = 0; +static int counter = 0; struct mixin_counter { diff --git a/gdb/unittests/optional/assignment/5.cc b/gdb/unittests/optional/assignment/5.cc index 4112e9f..8c27e7b 100644 --- a/gdb/unittests/optional/assignment/5.cc +++ b/gdb/unittests/optional/assignment/5.cc @@ -17,7 +17,7 @@ namespace assign_5 { -int counter = 0; +static int counter = 0; struct mixin_counter { diff --git a/gdb/unittests/optional/assignment/6.cc b/gdb/unittests/optional/assignment/6.cc index 423b3e7..da01fd5 100644 --- a/gdb/unittests/optional/assignment/6.cc +++ b/gdb/unittests/optional/assignment/6.cc @@ -17,7 +17,7 @@ namespace assign_6 { -int counter = 0; +static int counter = 0; struct mixin_counter { -- cgit v1.1