From 78d5933a43f8a4dd5fd54f5344a7dd9c2d4b8769 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 19 Jul 2019 12:59:35 -0600 Subject: Remove tui_clear_source_windows_detail The calls to tui_clear_source_windows_detail in tui_add_win_to_layout aren't needed, because (after the resize unification) resizing will update the window contents. Removing these calls lets us remove several other things as well. gdb/ChangeLog 2019-09-20 Tom Tromey * tui/tui-data.h (tui_clear_source_windows_detail): Don't declare. * tui/tui-layout.c (tui_add_win_to_layout): Don't call tui_clear_source_windows_detail. * tui/tui-winsource.h (struct tui_source_window_base) : Don't declare. * tui/tui-winsource.c (tui_source_window_base::clear_detail): Remove. * tui/tui-data.c (tui_clear_source_windows_detail): Remove. --- gdb/tui/tui-data.c | 9 --------- gdb/tui/tui-data.h | 1 - gdb/tui/tui-layout.c | 2 -- gdb/tui/tui-winsource.c | 11 ----------- gdb/tui/tui-winsource.h | 2 -- 5 files changed, 25 deletions(-) (limited to 'gdb/tui') diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c index c11aa43..833ea49 100644 --- a/gdb/tui/tui-data.c +++ b/gdb/tui/tui-data.c @@ -87,15 +87,6 @@ tui_set_win_with_focus (struct tui_win_info *win_info) } -/* Clear the pertinent detail in the source windows. */ -void -tui_clear_source_windows_detail () -{ - for (tui_source_window_base *win : tui_source_windows ()) - win->clear_detail (); -} - - /* Accessor for the term_height. */ int tui_term_height (void) diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h index 23f769f..be81950 100644 --- a/gdb/tui/tui-data.h +++ b/gdb/tui/tui-data.h @@ -295,7 +295,6 @@ extern void tui_set_term_height_to (int); extern int tui_term_width (void); extern void tui_set_term_width_to (int); extern struct tui_locator_window *tui_locator_win_info_ptr (void); -extern void tui_clear_source_windows_detail (void); extern struct tui_win_info *tui_win_with_focus (void); extern void tui_set_win_with_focus (struct tui_win_info *); extern int tui_win_resized (void); diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c index df7056a..d331a2f 100644 --- a/gdb/tui/tui-layout.c +++ b/gdb/tui/tui-layout.c @@ -207,7 +207,6 @@ tui_add_win_to_layout (enum tui_win_type type) && cur_layout != SRC_DISASSEM_COMMAND && cur_layout != SRC_DATA_COMMAND) { - tui_clear_source_windows_detail (); if (cur_layout == DISASSEM_DATA_COMMAND) show_layout (SRC_DATA_COMMAND); else @@ -219,7 +218,6 @@ tui_add_win_to_layout (enum tui_win_type type) && cur_layout != SRC_DISASSEM_COMMAND && cur_layout != DISASSEM_DATA_COMMAND) { - tui_clear_source_windows_detail (); if (cur_layout == SRC_DATA_COMMAND) show_layout (DISASSEM_DATA_COMMAND); else diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c index 7a4821d..4520a1a 100644 --- a/gdb/tui/tui-winsource.c +++ b/gdb/tui/tui-winsource.c @@ -253,17 +253,6 @@ tui_source_window_base::show_source_content () refresh_window (); } -/* See tui-data.h. */ - -void -tui_source_window_base::clear_detail () -{ - gdbarch = NULL; - start_line_or_addr.loa = LOA_ADDRESS; - start_line_or_addr.u.addr = 0; - horizontal_offset = 0; -} - tui_source_window_base::tui_source_window_base (enum tui_win_type type) : tui_win_info (type) { diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h index 4c98ca3..445cc7c 100644 --- a/gdb/tui/tui-winsource.h +++ b/gdb/tui/tui-winsource.h @@ -101,8 +101,6 @@ protected: public: - void clear_detail (); - /* Refill the source window's source cache and update it. If this is a disassembly window, then just update it. */ void refill (); -- cgit v1.1