From 7af389b892404edc76e1a60c59b354b785378fa5 Mon Sep 17 00:00:00 2001 From: Siva Chandra Date: Fri, 21 Mar 2014 06:42:50 -0700 Subject: [python] Fix gdb.Value.dynamic_type for reference values. gdb.Value.dynamic_type is supposed to work for reference and pointer values. However, the value object in the function 'valpy_get_dynamic_type' was being dereferenced using 'value_ind' irrespective of the value type being TYPE_CODE_PTR or TYPE_CODE_REF. This patch fixes that to use 'coerce_ref' for TYPE_CODE_REF values. ChangeLog: * python/py-value.c (valpy_get_dynamic_type): Use coerce_ref to dereference TYPE_CODE_REF values. testsuite/ * gdb.python/py-value.c: Improve test case. * gdb.python/py-value.exp: Add new test. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.python/py-value.c | 2 ++ gdb/testsuite/gdb.python/py-value.exp | 2 ++ 3 files changed, 9 insertions(+) (limited to 'gdb/testsuite') diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 991c4e8..6826ec4 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-04-07 Siva Chandra Reddy + + * gdb.python/py-value.c: Improve test case. + * gdb.python/py-value.exp: Add new test. + 2014-04-07 David Blaikie * lib/compiler.c: Identify the clang compiler. diff --git a/gdb/testsuite/gdb.python/py-value.c b/gdb/testsuite/gdb.python/py-value.c index 90dc055..4d1c9c6 100644 --- a/gdb/testsuite/gdb.python/py-value.c +++ b/gdb/testsuite/gdb.python/py-value.c @@ -58,6 +58,8 @@ struct Derived : public Base { }; Base *base = new Derived (); +Derived derived; +Base &base_ref = derived; void ptr_ref(int*& rptr_int) { diff --git a/gdb/testsuite/gdb.python/py-value.exp b/gdb/testsuite/gdb.python/py-value.exp index ed332db..13433fd 100644 --- a/gdb/testsuite/gdb.python/py-value.exp +++ b/gdb/testsuite/gdb.python/py-value.exp @@ -416,6 +416,8 @@ proc test_subscript_regression {exefile lang} { # Likewise. gdb_test "python print (gdb.parse_and_eval('base').dynamic_type)" \ "Derived \[*\]" + gdb_test "python print (gdb.parse_and_eval('base_ref').dynamic_type)" \ + "Derived \[&\]" # A static type case. gdb_test "python print (gdb.parse_and_eval('5').dynamic_type)" \ "int" -- cgit v1.1